https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • c

    Craig Gumbley

    02/23/2023, 3:25 PM
    @bastelfreak https://github.com/puppetlabs/puppet-lint/pull/87
  • v

    VoxBot

    02/23/2023, 3:32 PM
    craig: I think before https://github.com/puppetlabs/puppet-lint/pull/85 is merged we should think about the question is posted above, how do we handle puppet-lint vs puppet-lint-top_scope_facts-check vs voxpupuli-puppet-lint-plugins for existing installations
  • b

    bastelfreak

    02/23/2023, 4:19 PM
    @Craig Gumbley ^
  • c

    Craig Gumbley

    02/23/2023, 4:21 PM
    eek
  • c

    Craig Gumbley

    02/23/2023, 4:21 PM
    the hole gets deeper
  • c

    Craig Gumbley

    02/23/2023, 4:22 PM
    @David Sandilands anythoughts?
  • c

    Craig Gumbley

    02/23/2023, 4:24 PM
    My original thought was just to removed it from the vox gem
  • c

    Craig Gumbley

    02/23/2023, 4:25 PM
    With the version drop there is no reason not to upgrade to v3
  • d

    David Sandilands

    02/23/2023, 4:26 PM
    hmm interesting, I mean is there even a current way to deal with potential clashes / priority or would it be down to setting the template to ignore checks?
  • c

    Craig Gumbley

    02/23/2023, 4:40 PM
    not afaik
  • c

    Craig Gumbley

    02/23/2023, 4:40 PM
    Would it work if we did a breaking change for the vox gem @bastelfreak
  • c

    Craig Gumbley

    02/23/2023, 4:41 PM
    and set a requirement for puppet-lint vX?
  • v

    VoxBot

    02/23/2023, 4:42 PM
    I think for puppet-lint some agreement should be made on the direction and how to do gem development
  • v

    VoxBot

    02/23/2023, 4:42 PM
    using litmus for gems is just a horrible idea IMHO so why not cucumber? https://github.com/puppetlabs/puppet-lint/pull/89
  • v

    VoxBot

    02/23/2023, 4:42 PM
    that means you can easily run it locally as well
  • r

    ripienaar

    02/23/2023, 4:43 PM
    wow, cucumber, blast from the past 🙂
  • c

    Craig Gumbley

    02/23/2023, 4:44 PM
    i thought i’d taken litmus out of puppet-lint to be honest.. we don’t need anything above rspec for now
  • v

    VoxBot

    02/23/2023, 4:44 PM
    I guess you could also run it natively with rspec
  • c

    Craig Gumbley

    02/23/2023, 4:44 PM
    but additionally I think test tooling may be slightly out of scope for this particular change
  • c

    Craig Gumbley

    02/23/2023, 4:44 PM
    (certainly a topic we are wanting to talk about though)
  • v

    VoxBot

    02/23/2023, 4:45 PM
    IMHO you must get rid of the dependency on puppetlabs_spec_helper in puppet-lint
  • v

    VoxBot

    02/23/2023, 4:45 PM
    the circular dependency is just awful
  • v

    VoxBot

    02/23/2023, 4:45 PM
    yes
  • c

    Craig Gumbley

    02/23/2023, 4:46 PM
    for puppet-lint? have you got an example?
  • v

    VoxBot

    02/23/2023, 4:46 PM
    https://github.com/puppetlabs/puppet-lint/blob/dbc093c87cc001545c783e94e8d0d94cc290dfd4/Gemfile#L20
  • v

    VoxBot

    02/23/2023, 4:46 PM
    I think a new voxpupuli-puppet-lint-plugins release that requires puppet-lint 3.x will help for the plugin foobar
  • v

    VoxBot

    02/23/2023, 4:46 PM
    that's why I want to get rid of litmus there
  • v

    VoxBot

    02/23/2023, 4:47 PM
    if both mmkinst plugins are vendored into puppet-lint and dropped from our gem
  • s

    Slackbot

    02/23/2023, 4:53 PM
    This message was deleted.
    👍 2
    s
    b
    • 3
    • 4
  • s

    Slackbot

    02/23/2023, 4:53 PM
    This message was deleted.
    d
    d
    c
    • 4
    • 5
1...320321322...648Latest