https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    getting there!
  • v
    I tried to do whitespace changes only
  • v
    yeah whitespace and sorting
  • v
  • v
    heh in this case it shows "whitespace only" for whitespace only changes
  • v
    it didnt in the other
  • v
    github rather confused too, "viewed 42/42" but still presenting more files in and endless scroll
  • v
    you can remove &w=1 from the url
  • v
    might show you more fils
  • v
    oh!
  • v
    indeed
  • v
    ewoud: we could createa github action in modulesync_config that creates PRs for each module, when we push a new tag to modulesync_config
  • v
  • v
  • v
    bastelfreak: yes we should
  • v
    bastelfreak: or update the same PR, but then we should be careful not to lose manual changes
  • v
    yes. by default msync checks if a branch with the correct name already exists and will push to it
  • v
    ah you mean manual changes in a modulesync PR?
  • v
    maybe that forces us to work more with the .sync.yml
  • v
    I mean that sometimes we push changes like fix RuboCop in Ruby files and we shouldn't lose those commits
  • v
    but sometimes it's just better to manually rebase a modulesync branch if it's open for a long time
  • v
    so if it just creates a new commit on top of the branch, I'm fine with it
  • v
    IMHO the only reason we don't do it yet is that nobody has spent the time to build it; not that I don't want it :)
  • v
    exactly. I agree and I think that's already the way msync works
  • v
    yep
  • v
    :D
  • v
  • v
    ewoud: can you rereview the beaker PR? If you're fine with it we can merge it and I can do a new minor release
  • v
    yes, I marked it on my phone as "need to read"
  • v
    thanks
1...302303304...648Latest