# voxpupuli
- v
VoxBot
02/14/2023, 6:35 PMsecrets are not passed to actions from forks - v
VoxBot
02/14/2023, 6:36 PMand if the attacker can commit to the real repo, well… - v
VoxBot
02/14/2023, 6:37 PMmaybe it's worth re-evaluating some of this again, because that definitely was the case with the first iteration - v
VoxBot
02/14/2023, 6:38 PMWith the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.
- v
VoxBot
02/14/2023, 6:39 PMbastelfreak: want to bring that up in the next sync? - v
VoxBot
02/14/2023, 6:39 PMI can do that again, yes - v
VoxBot
02/14/2023, 6:39 PMcool. I'll see if someone from IT security can show up - a
Alex Fisher
02/14/2023, 7:17 PMSorry, can someone poke it again? - a
Alex Fisher
02/14/2023, 7:17 PMshould perhaps find a trivial typo in the README to submit a PR for... - v
VoxBot
02/14/2023, 7:27 PMo/ - v
VoxBot
02/14/2023, 7:27 PM - v
VoxBot
02/14/2023, 7:28 PMMight be great for those repositories where CI takes forever :-) - v
VoxBot
02/14/2023, 7:49 PMsmortex: o/ - v
VoxBot
02/14/2023, 7:50 PMsmortex: can I poke you on the release PR again? :) - v
VoxBot
02/14/2023, 7:51 PMbastelfreak: I guess so, I am fixing some docker crap now but can check after. Do you have the link at hand? - v
VoxBot
02/14/2023, 7:56 PM - a
Alex Fisher
02/14/2023, 8:13 PMahh... that'll be my problem https://github.com/puppetlabs/puppet-lint/actions/runs/4176549859/jobs/7233007453#step:7:1645 - a
Alex Fisher
02/14/2023, 8:14 PMGuess I'll move away from creating a fingerprint based on the whole message. - v
VoxBot
02/14/2023, 8:27 PMbinford2k: can you take a look at https://github.com/voxpupuli/puppet-puppet_authorization/pull/1 or poke some of the people maintaining the PE-forked modules? - a
Anthony Paragas
02/14/2023, 8:37 PMhey am trying to update this puppet key but can’t seem to find anything to resolve… am running this on ubuntu 16Copy code[8:50 PM] GPG error: <http://apt-mirror.abc.net/puppet> xenial InRelease: The following signatures were invalid: KEYEXPIRED 1629234366 KEYEXPIRED 1629234366 KEYEXPIRED 1629234366 - a
Anthony Paragas
02/14/2023, 8:37 PMhey am trying to update this puppet key but can’t seem to find anything to resolve… am running this on ubuntu 16Copy code[8:50 PM] GPG error: <http://apt-mirror.abc.net/puppet> xenial InRelease: The following signatures were invalid: KEYEXPIRED 1629234366 KEYEXPIRED 1629234366 KEYEXPIRED 1629234366 - v
VoxBot
02/14/2023, 8:40 PMbastelfreak: thanks! I think this docker mess is going to be fine: https://github.com/puppetlabs/puppetlabs-docker/pull/897 - v
VoxBot
02/14/2023, 8:40 PMAs far as i can see, this PR is okay for me. I opened a few questions but got no feedback so not sure about what to do for them. - v
VoxBot
02/14/2023, 8:41 PMdo you want me to rebase on top of master? - v
VoxBot
02/14/2023, 8:44 PMmaybe rebase and ping ewoud again about it - v
VoxBot
02/14/2023, 8:44 PMI need to check what was actually remaining in that PR - v
VoxBot
02/14/2023, 9:04 PMbastelfreak: rebased and tested locally on a module with the changes from https://github.com/voxpupuli/modulesync_config/pull/789, that looks good. - v
VoxBot
02/14/2023, 9:05 PMthanks! - a
Alex Fisher
02/14/2023, 9:52 PMI've updated https://github.com/puppetlabs/puppet-lint/pull/79 again if anybody is free to kick the build again...👍 1