https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • y

    Yury Bushmelev

    02/10/2023, 11:17 AM
    84 chars.. IIRC it should be <64
  • v

    VoxBot

    02/10/2023, 11:17 AM
    mhm I tested that before opening the PR
  • v

    VoxBot

    02/10/2023, 11:19 AM
    ewoud: I guess slack did that :D
  • y

    Yury Bushmelev

    02/10/2023, 11:19 AM
    Hostnames are composed of a sequence of labels concatenated with dots. For example, “en.wikipedia.org” is a hostname. Each label must be from 1 to 63 characters long. The entire hostname, including the delimiting dots, has a maximum of 253 ASCII characters.
  • y

    Yury Bushmelev

    02/10/2023, 11:19 AM
    so we can split by
    .
    instead of
    -
  • y

    Yury Bushmelev

    02/10/2023, 11:19 AM
    i.e. use “subdomains”
  • y

    Yury Bushmelev

    02/10/2023, 11:20 AM
    Copy code
    default: ${{ github.run_attempt }}.${{ github.run_id }}.${{ github.sha }}.<http://example.com|example.com>
  • y

    Yury Bushmelev

    02/10/2023, 11:20 AM
    ah.. it should start with letter IIRC.. so..
  • y

    Yury Bushmelev

    02/10/2023, 11:21 AM
    Copy code
    default: "A${{ github.run_attempt }}.R${{ github.run_id }}.S${{ github.sha }}.<http://example.com|example.com>
  • v

    VoxBot

    02/10/2023, 11:23 AM
    want to throw that in a PR and test in a module? :)
  • y

    Yury Bushmelev

    02/10/2023, 11:23 AM
    let me try as I have some spare time 🙂
  • v

    VoxBot

    02/10/2023, 11:24 AM
    \o/
  • y

    Yury Bushmelev

    02/10/2023, 11:28 AM
    that is from this PR, right? https://github.com/voxpupuli/puppet-yum/pull/297/files
  • v

    VoxBot

    02/10/2023, 11:31 AM
    yes, but it applies to all our modules with beaker jobs
  • y

    Yury Bushmelev

    02/10/2023, 11:33 AM
    I just realised every piece of hostname is < 63.. longest part is 53 chars
  • y

    Yury Bushmelev

    02/10/2023, 11:35 AM
    and funny thing is that FQDN is set as I see in the output.. but login prompt doesn’t show it
  • y

    Yury Bushmelev

    02/10/2023, 11:35 AM
    Copy code
    <http://centos7-64-puppet7.1-4135929116-5ddf79b6d43b8c83b0c4292134e1252e817baf44.example.com|centos7-64-puppet7.1-4135929116-5ddf79b6d43b8c83b0c4292134e1252e817baf44.example.com> 15:44:19$ cat /etc/resolv.conf
  • y

    Yury Bushmelev

    02/10/2023, 11:35 AM
    though.. maybe
    1-*
    is the problem.. let me try to add a letter there
  • v

    VoxBot

    02/10/2023, 11:36 AM
    well, that part is weird: why does it include http:// there?
  • y

    Yury Bushmelev

    02/10/2023, 11:36 AM
    I see no http:// 🤔 slack -> irc?
  • v

    VoxBot

    02/10/2023, 11:37 AM
    123529 < VoxBot_> <Yury Bushmelev>
    Copy code
    <http://centos7-64-puppet7.1-4135929116-5ddf79b6d43b8c83b0c4292134e1252e817baf44.example.com> 15:44:19$ cat /etc/resolv.conf
  • v

    VoxBot

    02/10/2023, 11:37 AM
    perhaps it's slack or the slack bridge trying to be smart
  • y

    Yury Bushmelev

    02/10/2023, 11:37 AM
    there is no http:// in slack.. so I guess it’s gateway issue
  • y

    Yury Bushmelev

    02/10/2023, 11:37 AM
    this is from https://github.com/voxpupuli/puppet-yum/actions/runs/4135929116/jobs/7149071572#step:5:92
  • v

    VoxBot

    02/10/2023, 11:38 AM
    yes, that's what I found weird: I didn't see it there
  • v

    VoxBot

    02/10/2023, 11:38 AM
    seems like my bridge adds it
  • y

    Yury Bushmelev

    02/10/2023, 11:42 AM
    https://github.com/voxpupuli/gha-puppet/pull/25
  • y

    Yury Bushmelev

    02/10/2023, 11:42 AM
    https://github.com/voxpupuli/gha-puppet/pull/25
  • y

    Yury Bushmelev

    02/10/2023, 11:42 AM
    I added
    n
    in front of the domain string
  • y

    Yury Bushmelev

    02/10/2023, 11:43 AM
    and quoted the string.. I’m a bit paranoid here 😄
1...290291292...648Latest