can I get a review for https://github.com/voxpupuli/puppet-network/pull/283

xD bastelfreak beat me!

:)

His PR wasn't rebased, hopefully that's not a problem right?

It was merged after a release

looked okay to me

github has this "rebase and merge" button, which is nice

This message was deleted.

they even display "the PR is out of sync with the main branch" sometimes now

:D

Zhenech: I think thats the case when you enforce a linear history via the github settings for that repo

bastelfreak, you mean by disabling merges? yeah, probably

mhm we cannot enforce our CI as required checks :(

that breaks our release process

(somebody should fix that)

Any ideas about this failure?

a bit harrd to read on the phone. looks like some facts are missing

Looks like ti was related to this https://github.com/puppetlabs/rspec-puppet/pull/19

Looks like ti was related to this https://github.com/puppetlabs/rspec-puppet/pull/19

hello, I’m looking at the current version of the puppet-jenkins module, version 2.0.0 from 2019, listed as compatible with Puppet at < 7.0.0 has anyone successfully used this module with Puppet 7? if not, this would be a blocker for a Puppet 7 upgrade

See the

puppet-jenkins

module at https://forge.puppet.com/puppet/jenkins?src=slack&amp;channel=voxpupuli

I would not think there is anything preventing use of 7 with it

try the master branch. we made a lot of changes but didnt release it yet

thanks 👍

any help on https://github.com/voxpupuli/puppet-jenkins/pull/1041 would be welcome, I think that would really help to get the 3.0.0 release out

Could this be related to the latest movement of forgeapi behind cloudfront?

"this"?

forgeapi-cdn has been miss-behaving, yes