https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    Do you have a workaround, by any chance? I have started migrating to PE2021 and stepped on this. So far only docker running systems have been affected
  • v
    if everyone ends up disabling the fact, it probably isn't a good default fact
  • v
    correct
  • j
    I think we should probably disable it by default
  • j
    I have to leave my desk in about 45mins but I will PR something later today
  • j
    @ewoud @bastelfreak it will probably be after hour for you guys by the time I'm back at my desk this afternoon. Are you in favor of disabling the udev fact by default or should we back it out completely?
  • v
    I'm not sure if we have a way to enable it if we do include it
  • v
    I guess you could use some env var, but that's going to unreliable
  • j
    external fact
  • v
    so I'm leaning to its own module
  • s
    This message was deleted.
    j
    • 2
    • 1
  • v
    easier to opt in for an entire environment
  • l
    then a profile could ensure => present content => '' to turn it on
  • v
    Lumiere: that would still mean you need 2 runs to get the fact, so if anything relies on the fact you can't converge in a single Puppet run
  • j
    yes
  • j
    the alternative is in the inverse, which would mean the first run would [always] push all the fact data
  • j
    the alternative is in the inverse, which would mean the first run would [always] push all the fact data
  • c
    There isn't a good way to push "opaque" data through. When PE bumped into this problem with the package inventory, the solution was to special-case it in the facts terminus: https://github.com/puppetlabs/puppetdb/blob/main/puppet/lib/puppet/indirector/facts/puppetdb.rb#L30-L32
  • v
  • v
    though we still have system_uptime and uptime_seconds in there because we parse it, but I wonder if that's really needed considering it's parsed in another layer
  • v
    some NM or networkd settings can be needed post factum though
  • j
    @Pat Riehecky I think I'm going to revert the udev fact PR completely... Maybe move it into a udevdb mod?
  • p
    Ok, I can work with that
  • j
    @Pat Riehecky I think I'm going to revert the udev fact PR completely... Maybe move it into a udevdb mod?
  • j
    I suspect some sort of filtering rules are going to needed to make it generally useful.
  • s
    This message was deleted.
    j
    b
    p
    • 4
    • 19
  • b
  • j
    I've opened a PR to revert the udev fact. https://github.com/voxpupuli/puppet-systemd/pull/316
  • j
    I've opened a PR to revert the udev fact. https://github.com/voxpupuli/puppet-systemd/pull/316
  • j
1...267268269...648Latest