# voxpupuli
- v
VoxBot
01/23/2023, 2:57 PMmy mood today: all software is a mess and since puppet-lint is software, it must also be a mess - v
VoxBot
01/23/2023, 2:57 PMbut can you be more specific? - a
Alex Fisher
01/23/2023, 2:57 PM - a
Alex Fisher
01/23/2023, 2:57 PM - a
Alex Fisher
01/23/2023, 2:58 PM - a
Alex Fisher
01/23/2023, 2:58 PM - a
Alex Fisher
01/23/2023, 2:58 PM'returns nothing' (other than some json maybe) - v
VoxBot
01/23/2023, 2:59 PMyes, the layers are done poorly - v
VoxBot
01/23/2023, 2:59 PMso https://github.com/puppetlabs/puppet-lint/blob/06f93da1debe7b45a12d1367a76ac671491b74c5/lib/puppet-lint.rb#L169-L189 does the printing, but also returns the JSON - v
VoxBot
01/23/2023, 3:00 PMand https://github.com/puppetlabs/puppet-lint/blob/06f93da1debe7b45a12d1367a76ac671491b74c5/lib/puppet-lint.rb#L228 is out of date, since it should return a JSON data of the problems too - a
Alex Fisher
01/23/2023, 3:00 PMI was going to feel bad about having a method called
conditionally write stuff to a file, but since it's already doing more than 'printing' I can live with it.print_problems - a
Alex Fisher
01/23/2023, 3:01 PMThe rake task doesn't use the returned data, and I don't think I gain much in editing both the task and the bin code paths. - v
VoxBot
01/23/2023, 4:35 PMewoud: I think it was you raising a possible issue with the Debian puppet agent package systemd unit being named "puppet-agent.service" now, and "puppet.service" only being an alias - v
VoxBot
01/23/2023, 4:35 PMthe package is already in testing with this change, but we can still revert that change before bookworm (debian 12) is released - v
VoxBot
01/23/2023, 4:36 PMI suppose this change also affects ubuntu - a
Alex Fisher
01/23/2023, 4:46 PMewoud: Of course I made up that bit about not having to poke the rake task...
is called once per file, so I do need to write the report from outside to get a single report covering all files with errors.print_problems - a
Alex Fisher
01/23/2023, 4:51 PMIf https://github.com/puppetlabs/puppet-lint/pull/79 looks vaguely (more) sane, then I'll finish it off with tests, docs, proper commit message etc. - a
Alex Fisher
01/23/2023, 4:51 PMIf https://github.com/puppetlabs/puppet-lint/pull/79 looks vaguely (more) sane, then I'll finish it off with tests, docs, proper commit message etc. - a
Alex Fisher
01/23/2023, 4:52 PMI think only having an option to output to a file is going to work out better than writing to stdout. - a
Alex Fisher
01/23/2023, 4:54 PMWhen invoked with rake, there might be other rake tasks called at the same time (eg.
or whatever). If they output anything on stdout, it wouldn't be useful.bundle exec rake validate lint spec - a
Alex Fisher
01/23/2023, 4:55 PMFor the target (only??) use-case of gitlab, you're always going to need a file output. - a
Alex Fisher
01/23/2023, 4:56 PMAnd it's helpful to continue to also output the usual output to stdout when writing the report file. - p
Pat Riehecky
01/23/2023, 5:48 PMI'll confess I wish the service had been
from day one, but I'd use my time machine on other things....puppet-agent - v
VoxBot
01/23/2023, 7:26 PMnow we got the psh release and it doesnt support puppet-lint 3 :( - v
VoxBot
01/23/2023, 7:29 PMhttps://github.com/puppetlabs/puppetlabs_spec_helper/pull/378 and that fails because of the latest ruby-concurrent release - v
VoxBot
01/23/2023, 7:29 PMsad - v
VoxBot
01/23/2023, 7:29 PMlavamind: correct, I did mention that - v
VoxBot
01/23/2023, 7:30 PMlavamind: I think compatibility with whatever puppet supplies is good - v
VoxBot
01/23/2023, 7:30 PMlavamind: and if you use drop in files, they must be defined with the original name; you can't place them on the alias (systemd gets confused) - v
VoxBot
01/23/2023, 7:30 PMright right