https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • p

    Pat Riehecky

    01/16/2023, 6:48 PM
    I'm pretty fond of https://github.com/voxpupuli/puppet-firewalld ,but I'd love to have the following PRs: merged: https://github.com/voxpupuli/puppet-firewalld/pull/332 https://github.com/voxpupuli/puppet-firewalld/pull/330 https://github.com/voxpupuli/puppet-firewalld/pull/324 https://github.com/voxpupuli/puppet-firewalld/pull/303
  • b

    bastelfreak

    01/17/2023, 7:54 PM
    @Pat Riehecky they need some tests and/or rebasing. if that something you can pick up? we are happy to help
  • p

    Pat Riehecky

    01/17/2023, 7:55 PM
    I'll throw it on my backlog
  • p

    Pat Riehecky

    01/17/2023, 7:55 PM
    For https://github.com/voxpupuli/puppet-firewalld/pull/330 I'm not sure how to go about building what was requested
  • p

    Pat Riehecky

    01/17/2023, 7:55 PM
    For https://github.com/voxpupuli/puppet-firewalld/pull/330 I'm not sure how to go about building what was requested
  • v

    VoxBot

    01/17/2023, 8:40 PM
    can I get a review for https://github.com/voxpupuli/puppet-autofs/pull/191 and https://github.com/voxpupuli/puppet-collectd/pull/1012 and https://github.com/voxpupuli/puppet-collectd/pull/1013
  • v

    VoxBot

    01/18/2023, 11:44 AM
    I was just pointed to vim-ale, which uses a language server and it's actually very nice
  • v

    VoxBot

    01/18/2023, 12:36 PM
    I still need to try that one out
  • v

    VoxBot

    01/18/2023, 12:37 PM
    dnf install vim-ale and it just worked (at least when I tried it out with Puppet)
  • y

    Yury Bushmelev

    01/18/2023, 1:03 PM
    hmm.. I’m still using the
    rodjek/vim-puppet
    with vim
  • v

    VoxBot

    01/18/2023, 1:03 PM
    I did find that as puppet-lint runs while you type you very quickly fix the errors
  • y

    Yury Bushmelev

    01/18/2023, 1:04 PM
    I’m using vscodium for big projects these days.. but maybe I should try it
  • y

    Yury Bushmelev

    01/18/2023, 1:05 PM
    vim-ale is just language server proxy, right? so puppet lang server is required additionally?
  • y

    Yury Bushmelev

    01/18/2023, 1:07 PM
    well.. found the answer 🙂 it has bunch of linters bundled with
  • y

    Yury Bushmelev

    01/18/2023, 1:07 PM
    well.. found the answer 🙂 it has bunch of linters bundled with
  • y

    Yury Bushmelev

    01/18/2023, 1:07 PM
    I’d highly recommend shellcheck and hadolint as well btw
  • v

    VoxBot

    01/18/2023, 1:08 PM
    https://github.com/dense-analysis/ale/blob/master/ale_linters/puppet/languageserver.vim I know that author: Ananace already did the hard work
  • v

    VoxBot

    01/18/2023, 1:09 PM
    ALE is a nice linter engine
  • y

    Yury Bushmelev

    01/18/2023, 1:09 PM
    \o/
  • v

    VoxBot

    01/18/2023, 1:09 PM
    guess I should try out https://github.com/puppetlabs/puppet-editor-services
  • v

    VoxBot

    01/18/2023, 2:40 PM
    ewoud: pleeeease let me know when you figure out how to run thag thingi properly
  • v

    VoxBot

    01/18/2023, 2:42 PM
    bastelfreak: it really surprises me there is no gem for it; https://github.com/puppetlabs/puppet-editor-services/tree/main/vendor says it must be installed in Puppet's env but you can use puppet's AIO gem command to do that
  • v

    VoxBot

    01/18/2023, 2:43 PM
    if you have an AIO
  • v

    VoxBot

    01/18/2023, 2:44 PM
    .o0 am I the only one who needs to whistle Old McDonald when hearing AIO?
    🐷 1
  • v

    VoxBot

    01/18/2023, 2:45 PM
    after this comment you may not be the only one
  • v

    VoxBot

    01/18/2023, 2:46 PM
    then there's also some joke about cattle in there
  • v

    VoxBot

    01/18/2023, 2:47 PM
    Personally, I've just pulled the repo, bundle install:ed it, and inserted my own little runme-script that does bundle exec puppet-languageserver $@
  • v

    VoxBot

    01/18/2023, 2:51 PM
    Seems like the runme isn't necessary nowadays, just pulled the repo and bundle install:ed it, and that seems enough to get the LSP component to run
  • v

    VoxBot

    01/18/2023, 2:53 PM
    it may have been intentional ;)
  • v

    VoxBot

    01/18/2023, 3:07 PM
    Ananace: looks like puppet itself is listed in the gem as a dependency
1...248249250...648Latest