Puppet Community

I have been busy lately, and see some CentOS 7 failures on non-vox projects that use the vox tooling: <https://github.com/ccin2p3/puppet-patterndb/pull/30>

<https://github.com/ccin2p3/puppet-patterndb/actions/runs/3888933968/jobs/6636755067#step:4:206>

(unable to ssh in SUT for acceptance tests)

smortex: caused by the new ubuntu 22. our latest action pins to ubuntu 20 runner

bastelfreak: o/ Thanks for the hint! I'll check it tomorow!

<https://github.com/voxpupuli/gha-puppet/pull/21> you can directly use our shared action if you like

yes, I put a significant effort into that with the aim of reducing the effort to do those kind of patches over a ton of modules and I'd love it if they were widely used in the ecosystem

Created a PR to fix this one: <https://github.com/voxpupuli/puppet-rsyslog/pull/209>

Sometimes I find looking at a somewhat contained patch helps along side the doc.  <https://github.com/voxpupuli/puppet-firewalld/commit/74f9640c954919491abe1f21d52dd4a6caed3331> might be useful to compare against the doc other folks sent you

when you need to hack on one of the modules, just create the PR with the puppet changes and we can walk together through the tests

Hahaha....you replied to my contribution at <https://github.com/voxpupuli/puppet-puppetboard/pull/377|puppet-puppetboard> and I have not yet replied regarding my inexperience with tests.

I'll try to put something together this week.

I appreciate the last two aren't puppet-rspec specific

yea, but I think the biggest issue for a lot of people getting into puppet testing is that they're not ruby devs

so they don't have knowledge of rspec, they're tryting to learn puppet testing, and don't really care about anything else

its something I would like to see some work on from Puppets side, it doesn't take as much ruby knowledge or effort as it might appear but theres a lack of a step by step explanation of how to use it well and build up

there were also previous discussions on Puppet Native testing approaches to remove this issue

mocks, using hiera would be a couple big ones

I started with puppet before ruby and rspec was really hard.. though I had a lot of examples in company’s puppet control repo luckily.. but it’s still hard sometimes :)

Maybe we should provide bunch of diverse examples as a short-term help solution 

<http://rspec-puppet.com> , <https://www.betterspecs.org/>, <https://relishapp.com/rspec/> are probably the best references and unhelpfully for now I have tried to write a big section on rspec in the Puppet book I'm working on with packt

I do think rspec has a lot of magic - some of it is good (I love nesting contexts to provide more specific params, effectively building up a scenario), some of it bad (it's hard to understand)

I love nesting contexts with loops, but I want some ways to control how that works (to allow quick base testing vs full testing)

yes, I'd also love to have more control over the fact sets we test on

like, testing on RHEL, CentOS, Rocky, Alma and who knows what else doesn't matter for most code

I'd also like it if you could somehow assert a class doesn't use facts, but it quickly does because of providers

funny things happen if you don't provide some in the test suite, like <https://github.com/puppetlabs/puppet/blob/736798e69a74601f4955f087a3c147c8a18e7542/lib/puppet/provider/service/init.rb#L24-L25> fails

Puppet.runtime[:facter].value(:operatingsystem) returns nil and then nil.downcase fails

it'd probably be much more reliable if they simply compared to Debian, Ubuntu and RedHat instead of downcase it

Is the person who ordered this list of log levels trying to trigger me on purpose? :wink: <https://github.com/puppetlabs/pdksync#logging-output>