https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • p

    Pat Riehecky

    01/09/2023, 5:24 PM
    I really don't see what is wrong here.....
  • v

    VoxBot

    01/09/2023, 6:11 PM
    Ok, starting work on replacing the old webhook script in
    puppet-r10k
    with
    webhook-go
  • d

    Dr Bunsen Honeydew

    01/09/2023, 6:11 PM
    See the
    puppet-r10k
    module at https://forge.puppet.com/puppet/r10k?src=slack&channel=voxpupuli
  • v

    VoxBot

    01/09/2023, 6:11 PM
    (I actually started a few days ago)
  • v

    VoxBot

    01/10/2023, 9:27 AM
    Hello! I hope this is the correct place to ask about https://github.com/voxpupuli/json-schema. If so, can anyone let me know how to get coverage working when running the tests, please?
  • v

    VoxBot

    01/10/2023, 9:33 AM
    knirirr: o/
  • v

    VoxBot

    01/10/2023, 9:33 AM
    coverage should be checked on each PR
  • v

    VoxBot

    01/10/2023, 9:33 AM
    do you want to run it locally?
  • v

    VoxBot

    01/10/2023, 9:34 AM
    https://github.com/voxpupuli/json-schema/blob/master/.github/workflows/test.yml#L27 it requires an environment variable
  • v

    VoxBot

    01/10/2023, 9:37 AM
    Thanks. Yes, I would like to run it locally. It looks like
    COVERAGE=yes rake test
    should do it, but the coverage directory isn't generated.
  • v

    VoxBot

    01/10/2023, 9:39 AM
    does it run into any errors?
  • v

    VoxBot

    01/10/2023, 9:39 AM
    can you put the output into a gist?
  • v

    VoxBot

    01/10/2023, 9:39 AM
    or a pastebin
  • v

    VoxBot

    01/10/2023, 9:42 AM
    One moment, please.
  • v

    VoxBot

    01/10/2023, 9:42 AM
    I'm not sure what kind of report is actually generates locally
  • v

    VoxBot

    01/10/2023, 9:42 AM
    you can also just create a PR if you like
  • v

    VoxBot

    01/10/2023, 9:43 AM
    you don't have to test it locally
  • v

    VoxBot

    01/10/2023, 9:44 AM
    Here's the gist: https://gist.github.com/knirirr/626555e2af0cfc3bf5f3e521a209c9aa
  • v

    VoxBot

    01/10/2023, 9:44 AM
    I was wanting to run it locally so I could make some changes and test before creating a PR. I use simplecov on another project to generate local reports, which are very useful.
  • v

    VoxBot

    01/10/2023, 9:51 AM
    mhm there's something missing
  • v

    VoxBot

    01/10/2023, 9:52 AM
    https://github.com/voxpupuli/json-schema/blob/master/Gemfile#L9 did you install the coverage group?
  • v

    VoxBot

    01/10/2023, 9:55 AM
    Apparently I didn't - thanks for spotting that.
  • v

    VoxBot

    01/10/2023, 9:59 AM
    I know at least some of our stuff :D
  • v

    VoxBot

    01/10/2023, 9:59 AM
    Thanks! Working now.
  • v

    VoxBot

    01/10/2023, 10:01 AM
    \o/
  • t

    tuxmea

    01/10/2023, 10:24 AM
    Feedback needed: https://github.com/voxpupuli/hiera-eyaml/issues/336
  • t

    tuxmea

    01/10/2023, 10:24 AM
    Feedback needed: https://github.com/voxpupuli/hiera-eyaml/issues/336
  • v

    VoxBot

    01/10/2023, 10:31 AM
    can I get a review for https://github.com/voxpupuli/puppet-nginx/pull/1535 ?
  • v

    VoxBot

    01/10/2023, 1:28 PM
    https://github.com/voxpupuli/modulesync_config/pull/807
  • v

    VoxBot

    01/10/2023, 1:28 PM
    after that I'm proposing to archive https://github.com/voxpupuli/pdksync_config
1...235236237...648Latest