https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • b

    bastelfreak

    12/21/2022, 8:38 AM
    so something seems to call it
  • y

    Yury Bushmelev

    12/21/2022, 8:38 AM
    Iโ€™d add explicit log message into the method to ensure.. as itโ€™s really strange that there is no reference to this module
  • y

    Yury Bushmelev

    12/21/2022, 8:38 AM
    or something else is calling it from any other place
  • y

    Yury Bushmelev

    12/21/2022, 8:39 AM
    (cronjob?)
  • b

    bastelfreak

    12/21/2022, 8:39 AM
    there's a systemd timer to import new modules from the forge, but that's not triggering it
  • b

    bastelfreak

    12/21/2022, 8:40 AM
    opening https://www.puppetmodule.info/modules/puppetlabs-apache/8.6.0 for the first time will trigger the load_yardoc_from_remote_module method
  • b

    bastelfreak

    12/21/2022, 8:40 AM
    Dec 21 09:38:50 voxpupu <http://puppetmodule.info|puppetmodule.info>[1081356]: 2022-12-21 09:38:50 +0100: Downloading remote module tarball for release puppetlabs-apache-8.6.0
  • y

    Yury Bushmelev

    12/21/2022, 8:41 AM
    ๐Ÿค”
  • b

    bastelfreak

    12/21/2022, 8:42 AM
    yes ๐Ÿ˜„
  • b

    bastelfreak

    12/21/2022, 8:43 AM
    so this is a method for LibraryVersion and that's used in app.rb and in the gem_store. We don't use gem_store directly, but module_store inherits from gem_store. I'm wondering if there's some kind of autowiring/sinatra magic
  • y

    Yury Bushmelev

    12/21/2022, 8:44 AM
    Copy code
    alias yardoc_file_for_remote_gem source_yardoc_file
          alias yardoc_file_for_remote_module source_yardoc_file
          alias yardoc_file_for_disk_on_demand source_yardoc_file
          alias yardoc_file_for_github source_yardoc_file
  • y

    Yury Bushmelev

    12/21/2022, 8:44 AM
    I believe this is somehow related..
  • b

    bastelfreak

    12/21/2022, 8:45 AM
    I thought so as well
  • b

    bastelfreak

    12/21/2022, 8:47 AM
    magic magic
  • b

    bastelfreak

    12/21/2022, 8:48 AM
    I should do a talk about our infra in the future
  • y

    Yury Bushmelev

    12/21/2022, 8:53 AM
    ah no.. there are โ€œ_for_โ€ methods but weโ€™re looking for โ€œ_from_โ€ method
  • y

    Yury Bushmelev

    12/21/2022, 8:53 AM
    ah no.. there are โ€œ_for_โ€ methods but weโ€™re looking for โ€œ_from_โ€ method
  • b

    bastelfreak

    12/21/2022, 8:54 AM
    yep
  • b

    bastelfreak

    12/21/2022, 8:56 AM
    git grep load_yardoc_from_remote_module
    doesn't find any references to it, just the definition. Similar to expand_module. that's defined in the same file and only load_yardoc_from_remote_module references it (that's the method that does the actual module download).
  • y

    Yury Bushmelev

    12/21/2022, 8:58 AM
    I guess itโ€™s easier to raise an exception in the method and see the backtrace ๐Ÿ˜„
  • b

    bastelfreak

    12/21/2022, 8:59 AM
    ๐Ÿ˜„
  • b

    bastelfreak

    12/21/2022, 8:59 AM
    not a bad idea
  • v

    VoxBot

    12/21/2022, 9:00 AM
    I think what's happening is https://github.com/lsegal/yard/blob/main/lib/yard/server/library_version.rb#L49-L66
  • v

    VoxBot

    12/21/2022, 9:01 AM
    and the call is https://github.com/lsegal/yard/blob/main/lib/yard/server/library_version.rb#L182-L186
  • b

    bastelfreak

    12/21/2022, 9:01 AM
    lol
  • b

    bastelfreak

    12/21/2022, 9:01 AM
    yes
  • v

    VoxBot

    12/21/2022, 9:01 AM
    (did I mention I dislike ruby for such practices?)
  • b

    bastelfreak

    12/21/2022, 9:01 AM
    https://gist.github.com/bastelfreak/5f207973c6f91685b565a361c404fc23 that's the trace
  • v

    VoxBot

    12/21/2022, 9:02 AM
    โ™ฅ๏ธ
  • v

    VoxBot

    12/21/2022, 9:02 AM
    the rest is left as an excercise to the reader
1...222223224...648Latest