https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    big +1 to that
  • v
    I wish Puppet itself had a built in default layout for the data directory - as long as you follow the convention, no hiera.yaml should be needed IMHO
  • v
    in https://github.com/voxpupuli/beaker-hiera we do generate some layout too (though that's global, not for modules) and I wonder if that should follow the same conventions
  • j
    UGH
  • j
    some idiot just pushed 5.0.0 release prep onto the master branch for puppet-lldpd... https://github.com/voxpupuli/puppet-lldpd/commits/master
  • d
  • j
    I'm not even if sure what the branch protection is... can I do a forced push on master to undo?
  • v
    yes, but not sure why you need to
  • j
    yes I can...
  • j
    well there was no PR for the release
  • v
    ah, yes
  • v
    I wish our changelog generator skipped issues that had a PR attached
  • j
    wait, no I can't... can't force push to master
  • j
    well, I guess that release is done
  • j
  • v
    could you submit a PR for 5.0.0 that updates the changelog? I added some labels
    🙏 1
  • j
  • j
  • s
    This message was deleted.
    j
    • 2
    • 2
  • a
    I'm wondering how harmful it would or wouldn't be if we did want to vanish the 3 commits pushed directly to master.
  • j
    depends on how many clones were sync'd after the push
  • s
    This message was deleted.
    j
    • 2
    • 1
  • j
    if we changed the rake target to open a PR for the -rc we could block direct pushes to master completely
  • v
    well, the message was "update CHANGELOG.md for 5.0.0 release", not actually "release 5.0.0"
  • a
    I think the release task itself needs to.
  • j
    because it commits on metadata.json and pushes it... there's no reason that has to be pushed to master
  • v
    technically what you can also do is submit the bump to rc0 in the original PR and "just" make sure the tag points to the correct commit
  • j
    what could possibly go wrong 😉
  • j
    https://github.com/voxpupuli/puppet-lldpd/actions/runs/3517080364 let us never speak of this incident again...
  • a
    No problem. That looks like it's a least the correct commit. (although I would have probably gone with ewoud's suggestion over commit message)
1...193194195...648Latest