https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • j
  • j
    If anyone has a moment to consider a release PR: https://github.com/voxpupuli/puppet-yum/pull/283
  • j
    If anyone has a moment to consider a release PR: https://github.com/voxpupuli/puppet-yum/pull/283
  • v
  • v
    yas
  • v
    thanks
  • s
    This message was deleted.
    👍🏻 1
    y
    • 2
    • 1
  • v
    hmm, that looks like an RSS feed I should add to my reader
  • d
    Hey I was just looking https://github.com/voxpupuli/rspec-puppet-facts#specifying-the-supported-operating-systems and while supplying hardware does seem to affect my tests, supplying operatingsystem versions such as in the examples does not using on_supported_os it seems to just use the metadata.json copy. Is this expected or am I missing something?
  • b
    I think on_supported_os always gets all OSes + major versions from metadata.json and you can pass a filter to on_supported_os
  • b
    and filtering works, when the syntax is correct. we use that in many places
  • d
    so we would expect it to only look at a passed filter or to merge the results of metadata.json and the filter?
  • d
    I'll check my syntax
  • b
    to only look at the passed filter
  • b
    I saw people having e.g. only debian 9 in metadata.json and using debian 10 in the filter, that didn't work
  • d
    ach I see what I've done
  • d
    hmm or i thought I had.... I'll come back
  • d
    sigh I had my vscode tabs muddled up 🫠 turns out if you are updating a file in another module it doesn't work 😂
  • b
    😄
  • d
    Maybe on a more helpful note I was wondering about
    Copy code
    No facts were found in the FacterDB for Facter v4.2.8 on {:operatingsystem=>"windows", :operatingsystemrelease=>"\"2019\"", :hardwaremodel=>"x86_64"}, using v3.14.1 instead
    I have a PR in for pecdm/peadm to allow us to stand up windows clients in azure fairly easily so could gather this. Are there any general demand for missing facts to know which ones are most useful?
  • d
    Maybe on a more helpful note I was wondering about
    Copy code
    No facts were found in the FacterDB for Facter v4.2.8 on {:operatingsystem=>"windows", :operatingsystemrelease=>"\"2019\"", :hardwaremodel=>"x86_64"}, using v3.14.1 instead
    I have a PR in for pecdm/peadm to allow us to stand up windows clients in azure fairly easily so could gather this. Are there any general demand for missing facts to know which ones are most useful?
  • b
    I even have a ticket somewhere in the FACTER project to provide new factsets during the facter release process
  • b
    if you can provide some factsets, that would be very much appreciated
    👍 1
  • d
  • b
    yep. maybe I need to respond there ...
  • d
    I'm happy to try and get some submitted hopefully next week. I pinged on the internal channel to try and find out from product what is going on. It would be good for Puppet 8 Facter 5 to have the release process sorted
  • b
    oh yes!
  • b
    awesome, thanks
  • g
    Could we please add @treydock (https://github.com/treydock) to VP?
  • g
    Could we please add @treydock (https://github.com/treydock) to VP?
1...185186187...648Latest