https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    11/04/2022, 11:05 AM
    https://github.com/theforeman/puppet-foreman_proxy grep for datacat in that repo
  • v

    VoxBot

    11/04/2022, 11:05 AM
    https://github.com/theforeman/puppet-foreman_proxy/blob/5c9db9433d7215d3f1cce112b930062a854eb83b/manifests/feature.pp#L7-L10 & https://github.com/theforeman/puppet-foreman_proxy/blob/5c9db9433d7215d3f1cce112b930062a854eb83b/manifests/register.pp#L42-L50 are the most relevant bits
  • v

    VoxBot

    11/04/2022, 11:06 AM
    that is there to set the features property on https://github.com/theforeman/puppet-foreman_proxy/blob/5c9db9433d7215d3f1cce112b930062a854eb83b/manifests/register.pp#L5-L13
  • f

    fe80

    11/04/2022, 11:23 AM
    Ah great I was looking on puppet-foreman
  • f

    fe80

    11/04/2022, 11:23 AM
    Ty
  • v

    VoxBot

    11/04/2022, 11:23 AM
    ah yes, I meant the Foreman project, not the Foreman module :)
  • v

    VoxBot

    11/04/2022, 11:23 AM
    something something naming :P
    😄 1
  • v

    VoxBot

    11/04/2022, 11:24 AM
    you mean the one that has a foreman_puppet that does integration with Puppet, while puppet-foreman does setting up with puppet
  • v

    VoxBot

    11/04/2022, 11:24 AM
    and then puppetdb_foreman does the integration with puppetdb and should have been foreman_puppetdb?
  • v

    VoxBot

    11/04/2022, 11:25 AM
    runs
  • v

    VoxBot

    11/04/2022, 11:29 AM
    yes, I'd love to rename puppetdb_foreman to foreman_puppetdb
  • v

    VoxBot

    11/04/2022, 11:30 AM
    just so much hassle
  • v

    VoxBot

    11/04/2022, 11:31 AM
    yes
  • b

    bastelfreak

    11/04/2022, 12:27 PM
    check https://github.com/voxpupuli/puppet-confluence/pull/211 for example, the CI doesn't pass and it needs to be fixed
  • b

    bastelfreak

    11/04/2022, 12:29 PM
    and for logstash, check https://github.com/voxpupuli/puppet-logstash/pull/408
  • j

    jhoblitt

    11/04/2022, 7:28 PM
    do we have a solution for templating
    ./examples/foo.pp
    into the
    README.md
    ?
  • j

    jhoblitt

    11/04/2022, 7:29 PM
    found yet another case of the readme being wrong
  • b

    bastelfreak

    11/04/2022, 7:34 PM
    IMO: delete examples/ and every code snippet in readme.md, move it into the classes as @example puppet-strings block
  • b

    bastelfreak

    11/04/2022, 7:34 PM
    so it gets automatically rendered into reference.md
  • j

    jhoblitt

    11/04/2022, 7:34 PM
    I used to do that but I rather like using ./example/foo.pp for acceptance tests as that way the code fragment gets puppet-linted
  • b

    bastelfreak

    11/04/2022, 7:35 PM
    yes, I would love to combine it :(
  • j

    jhoblitt

    11/04/2022, 7:35 PM
    I would like to use the same fragment in the readme and for the acceptance test
  • b

    bastelfreak

    11/04/2022, 7:35 PM
    yes exactly
  • b

    bastelfreak

    11/04/2022, 7:35 PM
    but who has the time to implement this
  • j

    jhoblitt

    11/04/2022, 7:35 PM
    I thought about processing the readme to pull out the fragment but that doesn't work so well for linting
  • b

    bastelfreak

    11/04/2022, 7:35 PM
    we considered it the other way around
  • b

    bastelfreak

    11/04/2022, 7:35 PM
    generate the readme.md
  • j

    jhoblitt

    11/04/2022, 7:36 PM
    oh, well I was figuring I could give ewoud a $50 gift card 😉
  • j

    jhoblitt

    11/04/2022, 7:36 PM
    isn't that how everything gets done?
  • b

    bastelfreak

    11/04/2022, 7:36 PM
    :D
1...181182183...648Latest