https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • m

    Marty Ewings

    10/25/2022, 1:30 PM
    https://github.com/derdanne/puppet-nfs/pull/155
  • v

    VoxBot

    10/25/2022, 1:43 PM
    bastelfreak: for "control repo testing" I use https://github.com/theforeman/foreman-infra/blob/master/puppet/Rakefile & https://github.com/theforeman/foreman-infra/tree/master/puppet/spec/fixtures
  • b

    bastelfreak

    10/25/2022, 1:43 PM
    thanks, will have a look
  • v

    VoxBot

    10/25/2022, 1:44 PM
    no fixture setup at all, just symlinks and regular module installation using g10k
  • v

    VoxBot

    10/25/2022, 1:44 PM
    our test modules are git submodules so that's all outside of fixtures
  • v

    VoxBot

    10/25/2022, 1:45 PM
    bastelfreak: oh, I should have also linked https://github.com/theforeman/foreman-infra/blob/master/puppet/spec/spec_helper.rb since there I just set the correct module_path
  • v

    VoxBot

    10/25/2022, 1:46 PM
    ah you don't use puppetlabs_spec_helper
  • v

    VoxBot

    10/25/2022, 1:46 PM
    that also sets module_path and it felt like I couldn't overwrite it. but maybe something else was wrong as well
  • v

    VoxBot

    10/25/2022, 1:54 PM
    yes, it might be good to write an equivalent of https://github.com/puppetlabs/puppetlabs_spec_helper/blob/main/lib/puppetlabs_spec_helper/module_spec_helper.rb that's control_repo_spec_helper.rb
  • v

    VoxBot

    10/25/2022, 1:56 PM
    yeah
  • v

    VoxBot

    10/25/2022, 1:56 PM
    testing control repos is always interesting
  • v

    VoxBot

    10/25/2022, 1:57 PM
    in an ideal world, you would get all available roles + their factsets from puppetdb, run acceptancetests for changes and catalogdiff
  • v

    VoxBot

    10/25/2022, 2:01 PM
    there is let(:node) in rspec-puppet, I wonder if you could work that up further
  • c

    Craig Gumbley

    10/25/2022, 3:03 PM
    I’ve just pushed this https://github.com/puppetlabs/puppet-strings/pull/333
  • g

    GitHub

    10/25/2022, 3:04 PM
    #333 (GH-332) Ensure PuppetStrings is loaded for tasks Pull request opened by chelnak Prior to this PR users would receive an Undefined Constant error when attempting to generate a reference file via the provided Rake tasks. This was caused by the compact testing style for modules added in v3.0. In this case the parent, PuppetStrings is not properly loaded before Tasks. As a result the error above is caused. This PR adds a new module declaration to tasks.rb that will ensure that the PuppetStrings is properly loaded. puppetlabs/puppet-strings ✅ All checks have passed 3/3 successful checks
    c
    • 2
    • 1
  • v

    VoxBot

    10/25/2022, 6:16 PM
    I think I finally figured out how to properly implement idempotent apply with proper debugging in acceptance tests
  • v

    VoxBot

    10/25/2022, 6:16 PM
    it always bothered me that you only saw the last few lines, which made debugging hard
  • v

    VoxBot

    10/25/2022, 6:17 PM
    ah awesome
  • v

    VoxBot

    10/25/2022, 6:17 PM
    and sometimes you want additional context, like run cat /var/log/something
  • v

    VoxBot

    10/25/2022, 6:17 PM
    let's see if I can submit a PR
  • v

    VoxBot

    10/25/2022, 6:36 PM
    so https://gist.github.com/ekohl/3763bd669bbbce2502648709ec5160f1 is a matcher that allows you to write it { expect('include motd').to apply.idempotently }
  • v

    VoxBot

    10/25/2022, 6:37 PM
    neat
  • v

    VoxBot

    10/25/2022, 6:42 PM
    question is: where should it live? beaker-rspec, beaker-puppet or voxpupuli-acceptance?
  • v

    VoxBot

    10/25/2022, 6:42 PM
    I'm leaning to beaker-rspec
  • v

    VoxBot

    10/25/2022, 6:43 PM
    I would say that beaker-puppet makes slightly more sense then beaker-rspec, only because someone not using puppet might be using beaker-rspec? (maybe. very maybe)
  • v

    VoxBot

    10/25/2022, 6:43 PM
    I think beaker-rspec makes the most sense
  • v

    VoxBot

    10/25/2022, 8:55 PM
    https://github.com/voxpupuli/beaker-rspec/pull/115 - I started this because I was missing feedback in Litmus but couldn't test it so I wrote it for Beaker
  • s

    Slackbot

    10/25/2022, 9:51 PM
    This message was deleted.
    h
    b
    • 3
    • 5
  • h

    Hugo Haakseth

    10/25/2022, 9:51 PM
    Hi all Is it possible get new release of https://github.com/voxpupuli/puppet-confluence and https://github.com/voxpupuli/puppet-logstash to the forge? The current 4.0.0 version of puppet-confluence has a dependency to puppet/mysql_java_connector < 4.0.0 which locks puppetlabs/stdlib to 5.2.0 ... The current The main branch seems to cover my needs.
  • h

    Hugo Haakseth

    10/25/2022, 9:56 PM
    Hi all Is it possible get new release of https://github.com/voxpupuli/puppet-confluence and https://github.com/voxpupuli/puppet-logstash to the forge? puppet-confluence 4.0.0 has a dependency to puppet/mysql_java_connector < 4.0.0 which locks puppetlabs/stdlib to 5.2.0 ... elastic-logstash 6.1.5 depend on puppetlabs/stdlib < 6.0.0 as well. The modules main branches seems to cover my needs right now.
1...168169170...648Latest