@bastelfreak Can certainly wait until Monday but releasing

firewalld

without needing to wait on #303 to figure out whatever it's doing would be appreciated. https://github.com/voxpupuli/puppet-firewalld/pull/326#issuecomment-1200246220

ewoud: can you take a look at https://github.com/voxpupuli/puppet-grafana/pull/292 ? that will fix the modulesync for us

I have a PR to fix the remaining CI errors for modulesync on

puppet-zabbix

too if you'd like to take a look at that as well. https://github.com/ekohl/puppet-zabbix/pull/1

See the

puppet-zabbix

module at https://forge.puppet.com/puppet/zabbix?src=slack&channel=voxpupuli

I have a PR to fix the remaining CI errors for modulesync on

puppet-zabbix

too if you'd like to take a look at that as well. https://github.com/ekohl/puppet-zabbix/pull/1

I've updated the PR for https://github.com/voxpupuli/puppet-puppet_authorization/pull/1 to incorporate the feedback from@bastelfreak and ekohl/ewould's reviews

I've updated the PR for https://github.com/voxpupuli/puppet-puppet_authorization/pull/1 to incorporate the feedback from@bastelfreak and ekohl/ewould's reviews

The PR at https://github.com/voxpupuli/puppet-hocon/pull/1 is ready for review and passes all check but one: the Puppet 6 / CentOS 7 acceptance test. It fails with this error:

An error occurred while loading ./spec/acceptance/conf_setting_spec.rb.
Failure/Error: elsif ENV['PUPPET_INSTALL_TYPE'] != 'foss' && Gem::Version.new(puppet_version) >= Gem::Version.new('4.0.0')
ArgumentError:
  Malformed version number string 2022-08-11 19:09:52.976682 WARN  puppetlabs.facter - locale environment variables were bad; continuing with LANG=C LC_ALL=C
  6.28.0

Is this error familiar to anyone? It's not clear what's causing it yet, and the other tests for Puppet 6 and CentOS 7 all pass.

The PR at https://github.com/voxpupuli/puppet-hocon/pull/1 is ready for review and passes all check but one: the Puppet 6 / CentOS 7 acceptance test. It fails with this error:

An error occurred while loading ./spec/acceptance/conf_setting_spec.rb.
Failure/Error: elsif ENV['PUPPET_INSTALL_TYPE'] != 'foss' && Gem::Version.new(puppet_version) >= Gem::Version.new('4.0.0')
ArgumentError:
  Malformed version number string 2022-08-11 19:09:52.976682 WARN  puppetlabs.facter - locale environment variables were bad; continuing with LANG=C LC_ALL=C
  6.28.0

Is this error familiar to anyone? It's not clear what's causing it yet, and the other tests for Puppet 6 and CentOS 7 all pass.

sounds like you're setting PUPPET_VERSION as an env var, or something like that

also, I'm going to respond on those PRs but today I'm recovering from a long weekend of moving stuff and catching up on work backlog

Is it possible to limit acceptance tests to one or more specific tests when running beaker? Eg.

puppet-zabbix/spec/acceptance/zabbix_host_spec.rb

See the

puppet-zabbix

module at https://forge.puppet.com/puppet/zabbix?src=slack&channel=voxpupuli

Can I get a review on https://github.com/voxpupuli/puppet-rhsm/pull/128 ?

Can I get a review on https://github.com/voxpupuli/puppet-rhsm/pull/128 ?

@Rathios

BEAKER_destroy=no BEAKER_setfile=debian11-64 BEAKER_HYPERVISOR=vagrant_libvirt bundle exec rspec spec/acceptance/foo.rb

works

can I get a review for https://github.com/voxpupuli/puppet-wireguard/pull/58

Fantastic, thank you

with https://github.com/voxpupuli/puppet-conntrackd/pull/4, i think conntrackd is ready to release. given that i've never done this before, could i get some eyes on that? 🙂

with https://github.com/voxpupuli/puppet-conntrackd/pull/4, i think conntrackd is ready to release. given that i've never done this before, could i get some eyes on that? 🙂

commented a bit 🙂

@bastelfreak Added the release action to the firewalld release PR

@bastelfreak Added the release action to the firewalld release PR

This message was deleted.

Hrm...double checking the Gemfile update

Looks like that should do it. There's a lot going on in 303 😕

Here goes nothing 🤞

https://github.com/voxpupuli/voxpupuli-acceptance/pull/38 rspec-github for our acceptance tests

ewoud: mhm it doesn't fail