# voxpupuli
- v
VoxBot
07/18/2022, 5:38 PMcan I get a review for https://github.com/voxpupuli/voxpupuli.github.io/pull/258 + #259 + #260 - v
VoxBot
07/18/2022, 5:53 PMLumiere: there's /etc/os-release now - v
VoxBot
07/18/2022, 6:02 PMhttps://github.com/voxpupuli/voxpupuli-test/pull/82 I'd like to release what I fixed this morning - v
VoxBot
07/18/2022, 7:51 PM - v
VoxBot
07/18/2022, 7:52 PMI think we should develop one universal standard protocol for sharing universal standards..... /s - v
VoxBot
07/18/2022, 7:54 PMtvaughan++ reshitposting that - d
Dr Bunsen Honeydew
07/18/2022, 7:54 PMtvaughan gained a level! (Karma: 8) - t
tvaughan
07/18/2022, 7:54 PMThe old memes never die.... - v
VoxBot
07/19/2022, 7:27 AM - v
VoxBot
07/19/2022, 11:04 AMhey, could I also get a review for https://github.com/voxpupuli/puppet-catalog-diff/pull/84 and https://github.com/voxpupuli/puppet-catalog-diff/pull/87 :) - a
Alex Fisher
07/19/2022, 6:00 PM - s
Slackbot
07/19/2022, 6:01 PMThis message was deleted.👍 1b- 2
- 1
- a
Alex Fisher
07/19/2022, 6:01 PMHave also created https://github.com/mmckinst/puppet-lint-top_scope_facts-check/pull/11 Another one where we'll have to wait and see. - v
VoxBot
07/19/2022, 8:32 PMcan I get a review for https://github.com/voxpupuli/facterdb/pull/254 - s
Slackbot
07/20/2022, 4:34 AMThis message was deleted.y- 2
- 1
- v
VoxBot
07/20/2022, 7:29 AMcan I get reviews for https://github.com/voxpupuli/puppet-catalog_diff/pull/90 and https://github.com/voxpupuli/facterdb/pull/256 - b
baurmatt
07/20/2022, 8:26 AMAbout https://github.com/voxpupuli/puppet-lint-topscope-variable-check/issues/15 I've been discussing this with @Alex Fisher privately, but because @ekohl already commented on that issue in no time, lets move it here publicly. - b
baurmatt
07/20/2022, 8:26 AMAbout https://github.com/voxpupuli/puppet-lint-topscope-variable-check/issues/15 I've been discussing this with @Alex Fisher privately, but because @ekohl already commented on that issue in no time, lets move it here publicly. - b
baurmatt
07/20/2022, 8:27 AMIt seems I'm wrong about $::setting. But I'm still confused why the lint plugin isn't complaining about $::enc and $::trusted which we also use in our code - a
Alex Fisher
07/20/2022, 8:27 AMI think we're both agreed that the leading :: is not necessary with
. Interesting aboutsettings
though...$::enc - a
Alex Fisher
07/20/2022, 8:28 AMAre you using those in a class, or just in site.pp? - b
baurmatt
07/20/2022, 8:28 AMBoth actually 🤔 - a
Alex Fisher
07/20/2022, 8:31 AMDue to some code that I think ewoud had already pointed out could actually be removed https://github.com/voxpupuli/puppet-lint-topscope-variable-check/blob/46489d09b636[…]721b39506675f17f2e/lib/puppet-lint/plugins/topscope_variable.rb it looks like the linter wouldn't moan about
if it appears in site.pp$::enc - a
Alex Fisher
07/20/2022, 8:31 AMDue to some code that I think ewoud had already pointed out could actually be removed https://github.com/voxpupuli/puppet-lint-topscope-variable-check/blob/46489d09b636[…]721b39506675f17f2e/lib/puppet-lint/plugins/topscope_variable.rb it looks like the linter wouldn't moan about
if it appears in site.pp$::enc - a
Alex Fisher
07/20/2022, 8:31 AMI can't see why it wouldn't complain elsewhere though. - b
baurmatt
07/20/2022, 8:32 AMStrange 🤔 Are those variable of another kind? VARIABLE vs. SUPER-SPECIAL-VARIABLE? - v
VoxBot
07/20/2022, 8:33 AMI did not know about $enc - s
Slackbot
07/20/2022, 8:33 AMThis message was deleted.b- 2
- 1
- v
VoxBot
07/20/2022, 8:33 AMhttps://puppet.com/docs/puppet/7/lang_facts_builtin_variables.html doesn't mention it