Puppet Community

<@U1PC2RAH0> Hi!  Did you ever have a crack at fixing <https://github.com/kuleuven/puppet-lint-manifest_whitespace-check/issues/10> ?

I'm struggling to write a failing spec test.

<@U1PC2RAH0> In <https://github.com/kuleuven/puppet-lint-manifest_whitespace-check/issues/10#issue-973616662>, he you mean `closing_bracket` instead of `closing_brace`? :wink:

possible, but usually I copy and paste those messages :thinking_face:

Works a lot better if I put your example in ./spec/puppet-lint/plugins/manifest_whitespace_closing_bracket_spec.rb instead of ./spec/puppet-lint/plugins/manifest_whitespace_closing_brace_spec.rb

Anyway... that was the *easy* bit.  Now to see if I can actually fix it!

<@U1PC2RAH0> <https://github.com/kuleuven/puppet-lint-manifest_whitespace-check/pull/15>

maybe wait a week or two for a response, otherwise fork? I think thats an org account for auniversity?

definitely looks like, I am wondering if finding people who have merged or committed to other repos and pinging them directly would help

Forking isn't the problem.  We don't have write on rubygems.

(Jo does, and not the org he works/worked for)

But either way, we should give him a while before being more direct! :slightly_smiling_face:

my only thought is that contacting him directly on github just as a "hey, not sure who the contact for this org goes to, can you either help or point us to a contact to help" shouldn't be too obnoxious

Excellent!  Is there anything I should do to get that rolling?

figure out who has permissions to migrate it to us ;D

We have some community contributions coming to overhaul  <https://github.com/puppetlabs/beaker-google/>.  All the other beaker stuff has migrated to voxpupuli with―should beaker-google come, too?

bastelfreak, it's a belgian university, maybe .be people from the cfgmgmt bubble know someone there?

I'm pretty sure some people from that university regularly attend cfgmgmtcamp and are Foreman users, but I could be mistaken (and that they were from the Ghent university)

<https://github.com/voxpupuli/voxpupuli-test/pull/80> should be a simple review :)

I'm completely lost in how this ever worked: <https://github.com/voxpupuli/rspec-puppet-facts/commit/21b679f45b9e20902af53161b5e1bd0b4fb723f7>

custom facts are strings, but all other facts are symbols?

<https://github.com/voxpupuli/rspec-puppet-facts/pull/91> mhm

&gt; This should also be fixed upstream in FacterDB

I now see that there's later a PR that adds a setting to it

but there was a reason for the facts being symbols in facterdb

this is not what I wanted to spend my time on today, but here we are

how did you notice this? I think not *all* custom facts are strings?

I'm quite sure I used them as symbols previously

I did this: add_custom_fact :systemd, -&gt;(os, facts) { require 'pry' ; binding.pry ; facts[:service_provider] == 'systemd' }

and now I wonder how this ever worked, it probably didn't