https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    07/13/2022, 1:31 PM
    if you left that nill should it pull 'all' branches, similar to a r10k environment deploy ?
  • v

    VoxBot

    07/13/2022, 1:32 PM
    points at dhollinger
  • v

    VoxBot

    07/13/2022, 1:32 PM
    (saw a few commits from people so wasn't sure who was driving the functionality)
  • s

    saz

    07/13/2022, 1:45 PM
    https://github.com/voxpupuli/puppet-augeasproviders_sysctl/issues/17 That's my issue 🙂
  • p

    Pat Riehecky

    07/13/2022, 7:02 PM
    any objection to merging in https://github.com/voxpupuli/puppet-logrotate/pull/195, I generally try not to do the actual merging on my own PRs but I think this is safe since the existing failures are already existing
    ❤️ 1
  • p

    Pat Riehecky

    07/13/2022, 7:02 PM
    any objection to merging in https://github.com/voxpupuli/puppet-logrotate/pull/195, I generally try not to do the actual merging on my own PRs but I think this is safe since the existing failures are already existing
  • s

    smortex

    07/13/2022, 7:02 PM
    Ha! Yes! My infamous
    ~/bin/vagrant
    Copy code
    #!/bin/sh
    
    for v in $(env | cut -d= -f1 | egrep '^(GEM|BUNDLE)'); do
      unset $v
    done
    
    /bin/vagrant "$@"
  • p

    Pat Riehecky

    07/13/2022, 9:19 PM
    Would someone be up to making a new forge release of puppet-logrotate.... my attempt to run https://voxpupuli.org/docs/releasing_version/ went badly....
  • d

    Dr Bunsen Honeydew

    07/13/2022, 9:19 PM
    See the
    puppet-logrotate
    module at https://forge.puppet.com/puppet/logrotate?src=slack&channel=voxpupuli
  • s

    Slackbot

    07/13/2022, 9:33 PM
    This message was deleted.
    p
    b
    • 3
    • 2
  • v

    VoxBot

    07/14/2022, 7:40 AM
    ewoud: https://gist.github.com/bastelfreak/4c2036df2d2cbc9836309e01b038a3aa I use this setup in my controlrepo to validate all metadata.json via your metadata_json_deps. do you have a nice idea to stop CI if the dependencies aren't correct?
  • v

    VoxBot

    07/14/2022, 7:40 AM
    bastelfreak: what do you mean by stop CI?
  • v

    VoxBot

    07/14/2022, 7:41 AM
    you mean that the rake task should set a non-zero exit code if something doesn't match?
  • v

    VoxBot

    07/14/2022, 7:42 AM
    yes
  • v

    VoxBot

    07/14/2022, 7:42 AM
    what I'd do is set some variable at the start and after https://github.com/ekohl/metadata_json_deps/blob/baca865572789220ca2ae3e15e306ad37d8e6fa0/lib/metadata_json_deps.rb#L102 set it to something
  • v

    VoxBot

    07/14/2022, 7:42 AM
    then make the method return that var
  • v

    VoxBot

    07/14/2022, 7:43 AM
    could even be exit_code = 0, then exit_code |= 1 if it doesn't match
  • v

    VoxBot

    07/14/2022, 7:43 AM
    and exit_code |= 2 if you found a deprecated module (if you want that)
  • v

    VoxBot

    07/14/2022, 7:43 AM
    then you get the exit code 3 if you have both unsatisfied and deprecated modules
  • v

    VoxBot

    07/14/2022, 7:44 AM
    sounds good
  • v

    VoxBot

    07/14/2022, 7:44 AM
    will you submit a PR?
  • v

    VoxBot

    07/14/2022, 7:45 AM
    and I think you'll need an exit() at https://github.com/ekohl/metadata_json_deps/blob/baca865572789220ca2ae3e15e306ad37d8e6fa0/bin/metadata-json-deps#L11 as well because I don't think Ruby takes the last value for an exit code
  • v

    VoxBot

    07/14/2022, 7:46 AM
    I will take a look at it later
  • v

    VoxBot

    07/14/2022, 7:49 AM
    ok, I have a PR almost ready - if you can test it that'd be great
  • v

    VoxBot

    07/14/2022, 7:50 AM
    ah awesome, yes
  • v

    VoxBot

    07/14/2022, 7:52 AM
    https://github.com/ekohl/metadata_json_deps/pull/10 is completely untested now - note you will need to modify your Rakefile
  • v

    VoxBot

    07/14/2022, 7:55 AM
    ah nice, will check that later
  • v

    VoxBot

    07/14/2022, 11:34 AM
    anyone around to take a look at https://github.com/voxpupuli/puppet-lldpd/pull/131 ? it has one unit test for a fact that fails on github but passes locally for me
  • v

    VoxBot

    07/14/2022, 11:34 AM
    if someone could try that locally, that would be helpful
  • v

    VoxBot

    07/14/2022, 1:08 PM
    bastelfreak: you need to mock which again i.e.
1...101102103...648Latest