maybe it makes sense to write some automation for that, open a PR when it detects a change

or really, when a new fact set to FacterDB is added

sounds doable

I already update it from time to time

https://github.com/theforeman/foreman-packaging/blob/64f5c0b06dc46db19245dfc179ac0ca071afc141/.github/workflows/bump_packages.yml#L90-L103 is an example of how to create a PR in a GH action while also running some script

That collectd run you peaked load at a 1/2 so still some growth if you can get it in.

it updates the existing PR if the same branch is used, so you can easily rerun the job without creating a ton of PRs

ewoud: maybe I can hack something on friday

frisbee[m]: working on it :D

hmm, this is a fun experiment so far: https://gist.github.com/ekohl/28443e6ba178c931bb69285e976568eb I am now rewriting some of the Ruby code, stuff like "if @x || @y" is now rewritten to "if $x or $y"

I just don't know how to properly insert the { yet, but end is replaced by }

mostly because I don't know where the if statement ends when looking at a token stream

This message was deleted.

hmm, that's precisely what I said about behavior change: it no longer looks at a newer facter version, instead makes it older

personally I am fine with that

but there's also a test that says facterversion 3.1 which now returns 3.1.6 but with my current patch it makes it <= 3.1 which equals 3.1.0

should that return from < 3.2?

'< 3.2' seems more correct / less bad

I'm also thinking of splitting up the PR into a separate one for a better changelog

yeah

ok, I'm redoing the patch and trying to make it compatible again

hmm, interesting case: if you request 3.9.5, should it return 3.8.0 (since it's <= 3.9.5) or 3.9.6 (since it's < 3.10)

3.8.0 looks a bit more reasonable for me

if there is no 3.9.[0-5]

ewoud: 3.8.0

let's have that discussion in https://github.com/voxpupuli/rspec-puppet-facts/pull/151

and https://github.com/voxpupuli/rspec-puppet-facts/pull/152 will be the follow up, but let's first focus on 151

and the 3.9.5 case can be followed up here: https://github.com/voxpupuli/rspec-puppet-facts/pull/151/files#r1252961976

Does you guys have a kind of check to find Puppet Stdlib 9.x incombilities like https://gist.github.com/cruelsmith/197b72fec23e567bf6a3cb523644a2b7 or do you only checks things via spec test? I ask since we also use modules that have not PDK or modulesync support currently and still need to checks if they are working with Stdlib 9.x or not.