I needed an easy way for a customer to use images that have puppet preinstalled and that's working fine

bastelfreak: just thinking out loud: if you call host.install_package(package_name) if it's preinstalled, does that work?

bastelfreak: because if so, we could also implement BEAKER_PUPPET_COLLECTION=none to avoid calling install_puppet_release_repo_on, which could also help if you want to do something like testing the OS packaged Puppet

mhm could work

if so, the patch is much smaller and we have fewer env vars

bastelfreak, I did a nit-picky review of https://github.com/theforeman/foreman-packaging/pull/9517 -- can be merged afterwards

(eveything is just cosmetics, function wise it should be good as it is)

ewoud: https://github.com/voxpupuli/voxpupuli-acceptance/pull/62 is that what you had in mind?

bastelfreak: pretty much yes, or we could implement it in beaker_puppet_helpers

Zhenech: thanks, will check later

ewoud: I'm fine with both. I don't have a preference

bastelfreak: the only thing I wonder about is: https://github.com/voxpupuli/beaker_puppet_helpers/blob/4fdb3e48b0fb9e316ef13ab71a5fb876da8a4583/lib/beaker_puppet_helpers/install_utils.rb#L66

and I still wonder why that edge case is needed

because /etc/profile.d/ is only used for interactive/login shells on debian

yes, but is there another way to hack around that?

I don't think so

I think we should always call host.add_env_var('PATH', '/opt/puppetlabs/bin')

I don't see any issue in it and calling it always removes some logic

looks like /etc/bashrc on Fedora reads /etc/profile.d on non-login shells and on Debian it's /etc/profile that reads /etc/profile.d

https://unix.stackexchange.com/questions/170493/login-non-login-and-interactive-non-interactive-shells/170499#170499 hmm yes

https://github.com/voxpupuli/voxpupuli-acceptance/pull/62/files this would work and would have the smallest diff

that would end up in a situation where host.add_env_var is called twice, but the method checks that and won't append a path twice to $PATH

will give that a try at $customer

ewoud: works fine for me. From my point of view we can merge that

merged

Do someone know if it is intended by puppet package that is also checks with whatprovides on REHL?

Debug: Executing: '/bin/rpm -q npm --nosignature --nodigest --qf %{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\n'
Debug: Executing: '/bin/rpm -q npm --nosignature --nodigest --qf %{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\n --whatprovides'
Notice: /Stage[main]/Nodejs::Install/Package[npm]/ensure: current_value '2:16.20.1-1nodesource', should be 'absent' (noop) (corrective)

Found that while using the default setting of voxpupuli-nodejs

Which in the end leads to a loop where puppet install the nodejs package and remove it via

Package[npm]

again ...

Found a issues that relates to it and left my founds there: https://github.com/voxpupuli/puppet-nodejs/issues/452#issuecomment-1620245201