https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • a

    Alex Fisher

    06/16/2023, 8:49 AM
    Meanwhile, any thoughts on https://github.com/puppetlabs/puppetlabs-stdlib/issues/1373?
  • a

    Alex Fisher

    06/16/2023, 8:50 AM
    I think I’m fine with spamming warnings TBH.
  • v

    VoxBot

    06/16/2023, 8:50 AM
    bastelfreak, =2.7
  • v

    VoxBot

    06/16/2023, 8:51 AM
    bastelfreak, today we only deploy on 2.7. if the code is 3.0+ compatible that's great, but core isn't yet ;)
  • v

    VoxBot

    06/16/2023, 8:52 AM
    nice
  • b

    bastelfreak

    06/16/2023, 8:52 AM
    @Alex Fisher I'm still unsure. My initial thought was to not add the shims at all and drop all the legacy functions
  • a

    Alex Fisher

    06/16/2023, 9:30 AM
    Lol. That’s creates an awful lot of pain.
  • b

    bastelfreak

    06/16/2023, 9:31 AM
    more pain than we've now?
  • a

    Alex Fisher

    06/16/2023, 9:33 AM
    The pain now is mostly reserved for those already with strict mode turned on. Removing the shims would create pain for everyone
  • b

    bastelfreak

    06/16/2023, 9:35 AM
    then they will have the pain when stdlib 10 comes out
  • b

    bastelfreak

    06/16/2023, 9:36 AM
    under the assumptions that we don't forget to remove the deprecated functions
  • a

    Alex Fisher

    06/16/2023, 9:50 AM
    But you get the chance to upgrade your modules over a period of time. Right now you might have to upgrade everything in a single commit to your Puppetfile. This isn’t an option for a lot of folks.
  • b

    bastelfreak

    06/16/2023, 9:54 AM
    yeah I know. maybe the approach with just calling warn() and notify{} works better
  • a

    Alex Fisher

    06/16/2023, 9:55 AM
    Adding resources to the catalog is much more intrusive though.
  • b

    bastelfreak

    06/16/2023, 9:56 AM
    who reads puppetserver.log? 🙂
    💯 2
  • a

    Alex Fisher

    06/16/2023, 9:56 AM
    (And a harder change to implement)
  • b

    bastelfreak

    06/16/2023, 9:56 AM
    how do you convince people to upgrade when you're not intrusive
  • a

    Alex Fisher

    06/16/2023, 9:57 AM
    But it gives time for all the module authors to get releases out (and follow up bug fix releases etc)
  • a

    Alex Fisher

    06/16/2023, 9:58 AM
    When the time comes to switch the deprecations to errors, there’s hopefully a lot fewer things you have to fix.
  • a

    Alex Fisher

    06/16/2023, 10:00 AM
    I want to remove the blockers to upgrading. Right now, to get latest versions of eg. our modules you now require stdlib 9. But maybe you can’t upgrade to that because of X other modules you have.
  • b

    bastelfreak

    06/16/2023, 10:04 AM
    I think the root cause is that the new functions aren't available in stdlib 8
  • b

    bastelfreak

    06/16/2023, 10:04 AM
    that would have enabled maintainers and users to switch to them while being compatible with stdlib 8 and 9
  • a

    Alex Fisher

    06/16/2023, 10:05 AM
    But that’s what 9 should be. A forgiving version with both.
  • b

    bastelfreak

    06/16/2023, 10:05 AM
    from a users point of view I want a smooth migration with updating as few modules as possible in one batch. as a maintainer I want to do such cleanups as rarely as possible.
  • a

    Alex Fisher

    06/16/2023, 10:07 AM
    We can leave the shims in for multiple major versions if we like. I think time is a better metric than number of major versions.
  • b

    bastelfreak

    06/16/2023, 10:10 AM
    https://github.com/puppetlabs/puppetlabs-stdlib/pull/1356/files#diff-4e85a10f76804468f04ac128ab0791053a58eebc3e6b83117dd14ef5bd8acba8 I think this should have been two PRs
  • b

    bastelfreak

    06/16/2023, 10:11 AM
    an enahncement that adds the namespaced function, release that, and 9 should have deprecated the old functions
  • b

    bastelfreak

    06/16/2023, 10:11 AM
    cant we just backport that to 8.7
  • a

    Alex Fisher

    06/16/2023, 10:23 AM
    I think that ship sailed, but we could get 9.0.1 out where the deprecations are ‘softened’
  • b

    bastelfreak

    06/16/2023, 10:23 AM
    we could do both?
1...514515516...643Latest