https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • a

    Alex Fisher

    05/25/2023, 3:24 PM
    ewoud: Got a moment to advise on a github workflow config?
  • a

    Alex Fisher

    05/25/2023, 3:25 PM
    Specifically, this isn't right. https://github.com/voxpupuli/puppet-ldapquery/pull/47/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR15
  • a

    Alex Fisher

    05/25/2023, 3:25 PM
    Is there a way of depending on a job that comes in from voxpupuli/gha-puppet/.github/workflows/basic.yml@v1
  • a

    Alex Fisher

    05/25/2023, 3:25 PM
    or do I just depend on the 'Puppet' job...???
  • v

    VoxBot

    05/25/2023, 3:26 PM
    mhm
  • v

    VoxBot

    05/25/2023, 3:26 PM
    can you depend on a job from a shared workflow
  • v

    VoxBot

    05/25/2023, 3:28 PM
    I'm also not sure if you can access the variables from the shared workflow
  • v

    VoxBot

    05/25/2023, 3:29 PM
    bastelfreak: yes, I know that now but that wasn't a thing back then
  • a

    Alex Fisher

    05/25/2023, 3:29 PM
    I need to do something similar to voxpupuli/gha-puppet/.github/workflows/basic.yml@v1 but I think that preexisted the shared workflows and didn't look too DRY.
  • v

    VoxBot

    05/25/2023, 3:29 PM
    ewoud: ah okay
  • v

    VoxBot

    05/25/2023, 3:29 PM
    afisher: doesn't needs: puppet work?
  • v

    VoxBot

    05/25/2023, 3:29 PM
    afisher: and I don't think you can get outputs from a workflow inside a reusable workflow, though I've never tried
  • v

    VoxBot

    05/25/2023, 3:30 PM
    afisher: I just copied the whole workflow, but I like the idea of reusing at least part of it
  • a

    Alex Fisher

    05/25/2023, 3:30 PM
    Can I just add steps to an imported/reuseable workflow instead?
  • a

    Alex Fisher

    05/25/2023, 3:30 PM
    :wq
  • a

    Alex Fisher

    05/25/2023, 3:31 PM
    (sorry wrong terminal!) (and computer!)
  • v

    VoxBot

    05/25/2023, 3:31 PM
    it's all one cloud now, right? :)
  • a

    Alex Fisher

    05/25/2023, 3:31 PM
    or... Slack isn't even allowed on my corporate laptop anymore...
    ➕ 1
  • v

    VoxBot

    05/25/2023, 3:32 PM
    booooooooh corporate!
  • v

    VoxBot

    05/25/2023, 3:33 PM
    afisher: https://github.com/voxpupuli/puppet-vault_lookup/blob/master/.github/workflows/ci.yml comes to mind as a similar setup where it uses a custom setfile
  • v

    VoxBot

    05/25/2023, 3:33 PM
    we did fight to get puppetserver to run in a container and then link to it
  • v

    VoxBot

    05/25/2023, 3:34 PM
    https://docs.github.com/en/actions/using-containerized-services/about-service-containers would that be a solution?
  • a

    Alex Fisher

    05/25/2023, 3:34 PM
    yeah, I'm trying to do something similar and run openldap in a container. Any function unit tests really aren't that much use here IMO.
  • a

    Alex Fisher

    05/25/2023, 3:35 PM
    Is that new?
  • v

    VoxBot

    05/25/2023, 3:35 PM
    not really
  • v

    VoxBot

    05/25/2023, 3:35 PM
    if that works, we can extend gha-puppet to accept a services parameter where you pass that in
  • a

    Alex Fisher

    05/25/2023, 3:36 PM
    ok, well that looks a lot neater. Maybe there was a good reason that couldn't be done for the gitlab_runner module, but I can try that approach here instead. Sounds much easier than messing around with facts and modifying /etc/hosts etc.
  • v

    VoxBot

    05/25/2023, 3:37 PM
    I had problems connecting from a beaker container to another container in vault_lookup, so be warned
  • v

    VoxBot

    05/25/2023, 3:38 PM
    mhm Robert Waffen and I might have fixed that
  • v

    VoxBot

    05/25/2023, 3:38 PM
    we did some changes in beaker-docker
1...492493494...642Latest