# voxpupuli
- y
Yury Bushmelev
05/05/2023, 12:12 PMI’d say I know some tricks.. but have no clear understanding how it works in details 🙂 let me have a look - b
bastelfreak
05/05/2023, 12:12 PMbecause we don't mock ENV.fetch: https://github.com/voxpupuli/beaker-puppet/pull/220/files#diff-7612e8b330ceb1b2d78e89b0bef12e857228f13d8804975163c5855d678318a1R58 - y
Yury Bushmelev
05/05/2023, 12:15 PMI’d say we should mock it then - y
Yury Bushmelev
05/05/2023, 12:17 PMor even better.. those defaults should be default values of a function parameters - y
Yury Bushmelev
05/05/2023, 12:17 PMso it’ll use variables if no params passed - b
bastelfreak
05/05/2023, 12:17 PMI'm open for patches 😄 - b
bastelfreak
05/05/2023, 12:17 PMnot sure how to mock that properly - y
Yury Bushmelev
05/05/2023, 12:18 PMCopy codeallow(ENV).to receive(:[]) # stub a default value first if message might be received with other args as well. allow(ENV).to receive(:[]).with(name).and_return(value) - y
Yury Bushmelev
05/05/2023, 12:18 PMquick googling/stackoverflowing (I’m too old for ChatGPT)😁 1 - v
VoxBot
05/05/2023, 12:20 PM - y
Yury Bushmelev
05/05/2023, 12:20 PMhttps://github.com/voxpupuli/beaker-puppet/blob/f0ce27306945c4d60e4383f03971a598e17df6d9/spec/beaker-puppet/install_utils/foss_utils_spec.rb#L207 As I see [] is mocked.. so you should add the same but for
.. and maybe dropreceive(:fetch)
at all if only fetch is used now[] - v
VoxBot
05/05/2023, 12:21 PMindeed, though I wonder how useful the ENV.fetch cop really is - y
Yury Bushmelev
05/05/2023, 12:21 PMthe only profit is default value as I see - v
VoxBot
05/05/2023, 12:21 PMno, it also raises an error if the var is not set - y
Yury Bushmelev
05/05/2023, 12:21 PMah, well.. - v
VoxBot
05/05/2023, 12:21 PMso ENV.fetch('bla') will fail if bla is not set - y
Yury Bushmelev
05/05/2023, 12:22 PMnot a big deal if you’re ok with nil in the end - y
Yury Bushmelev
05/05/2023, 12:23 PMthough I’d move picking the env vars values as defaults to the function parameters (where those are nil by default) - y
Yury Bushmelev
05/05/2023, 12:23 PMI believe there is no reason to test ENV.fetch() 🙂 - v
VoxBot
05/05/2023, 12:24 PMyes, it can certainly be better to have defaults specified with fetch - v
VoxBot
05/05/2023, 12:30 PMso should we stick with ENV? - v
VoxBot
05/05/2023, 12:35 PMupdated it to stick with ENV - v
VoxBot
05/05/2023, 12:45 PM - v
VoxBot
05/05/2023, 12:47 PMargh, I missed that one? I earlier had it in https://github.com/voxpupuli/beaker/pull/1762 but missed it - v
VoxBot
05/05/2023, 12:48 PMthis is a backport to 4.x. it's fixed already in master/in the 5.x releases - v
VoxBot
05/05/2023, 12:49 PMah - still, I expected it to be in that PR - v
VoxBot
05/05/2023, 12:49 PMah okay - v
VoxBot
05/05/2023, 12:52 PM - v
VoxBot
05/05/2023, 1:34 PMand the last rubocop change: https://github.com/voxpupuli/beaker-puppet/pull/221 - v
VoxBot
05/05/2023, 2:18 PMcan I get a review for https://github.com/voxpupuli/beaker-docker/pull/118 and https://github.com/voxpupuli/beaker-docker/pull/117