# voxpupuli
- b
bastelfreak
05/03/2023, 8:20 AM\o/ - m
Marty Ewings
05/03/2023, 8:20 AMPuppet Magic! - g
giphy
05/03/2023, 8:21 AMmagic - v
VoxBot
05/03/2023, 3:42 PMbastelfreak: Still having to fight with reworking tests for the webhook stuff. Would it be easier to have webhook into a separate module? - v
VoxBot
05/03/2023, 3:46 PMwhich issues do you have? - v
VoxBot
05/03/2023, 3:49 PMshouldnt that be straight forward in the r10k module? download go binary, write config, use systemd::unit_file to start the service? - v
VoxBot
05/03/2023, 4:01 PMbastelfreak: I suppose, but I was pulling down the built packages and the current r10k tests make a lot of assumptions about what webhook supports that webhook-go can't support (yet) - v
VoxBot
05/03/2023, 4:01 PMsuch as Mcollective support - v
VoxBot
05/03/2023, 4:01 PMah just drop those tests - v
VoxBot
05/03/2023, 4:01 PMand trying to untie all those tests has been a pain - v
VoxBot
05/03/2023, 4:04 PMI would rip all of that out in one pr. then add support for the new webhook - v
VoxBot
05/03/2023, 4:05 PMAhh, that's probably a better idea - v
VoxBot
05/03/2023, 4:06 PMyeah. we need to rip it out anyways - n
natemccurdy
05/04/2023, 12:14 AMFinally got acceptance tests working on
with the latest modulesync: • https://github.com/voxpupuli/puppet-vault_lookup/pull/80 For review please.vault_lookup - n
natemccurdy
05/04/2023, 12:14 AMAnd by "working" I mean, "told modulesync not to update the CI file" 🤷 - v
VoxBot
05/04/2023, 6:56 PMGot a puppet-r10k PR: - d
Dr Bunsen Honeydew
05/04/2023, 6:56 PMSee the
module at https://forge.puppet.com/puppet/r10k?src=slack&channel=voxpupulipuppet-r10k - v
VoxBot
05/04/2023, 6:56 PM#### This Pull Request (PR) fixes the following issues - v
VoxBot
05/04/2023, 6:56 PM<!-- - d
Dr Bunsen Honeydew
05/04/2023, 6:56 PM<! lost a level. (Karma: -1) - v
VoxBot
05/04/2023, 6:56 PMReplace this comment with the list of issues or n/a. - v
VoxBot
05/04/2023, 6:56 PMUse format: - v
VoxBot
05/04/2023, 6:56 PMFixes #123 - v
VoxBot
05/04/2023, 6:56 PMFixes #124 - v
VoxBot
05/04/2023, 6:56 PM--> - d
dhollinger
05/04/2023, 6:56 PMfacepalm - d
dhollinger
05/04/2023, 6:56 PMstupid clipboard - v
VoxBot
05/04/2023, 6:57 PMLet's try this again: - v
VoxBot
05/04/2023, 6:57 PMr10k module PR: https://github.com/voxpupuli/puppet-r10k/pull/594 - v
VoxBot
05/04/2023, 6:57 PMdhollinger: o/