https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    04/28/2023, 10:38 AM
    yes its just the feature file which they both have
  • v

    VoxBot

    04/28/2023, 10:38 AM
    ill probably just fix up both files so they are the same but thats definetly not the right fix
  • v

    VoxBot

    04/28/2023, 10:38 AM
    I think you can rename it
  • v

    VoxBot

    04/28/2023, 10:39 AM
    but should i send a fix to augeasproviders_core to rename it?
  • v

    VoxBot

    04/28/2023, 10:39 AM
    maybe to both and make them identical
  • v

    VoxBot

    04/28/2023, 10:40 AM
    ack ill send a patch to augees_core then and add the froxen string comment
  • z

    zipkid

    04/28/2023, 11:00 AM
    https://github.com/voxpupuli/puppet-varnish/pull/19 Spec test added.
  • z

    zipkid

    04/28/2023, 11:03 AM
    Not sure what’s up with apt-key on Puppet6….
  • v

    VoxBot

    04/28/2023, 11:06 AM
    bastelfreak: well, thanks for that … now I had to open https://github.com/puppetlabs/forge-ruby/pull/103
  • v

    VoxBot

    04/28/2023, 11:07 AM
    :D
  • v

    VoxBot

    04/28/2023, 11:07 AM
    I just updated to Fedora 38 yesterday so that means Ruby 3.2 is now my default
  • v

    VoxBot

    04/28/2023, 11:11 AM
    and https://github.com/puppetlabs/forge-ruby/pull/104 was what I really wanted to submit
  • y

    Yury Bushmelev

    04/28/2023, 11:22 AM
    how bad is it to mix using () and not using them in the same source file (rspec actually)?
  • y

    Yury Bushmelev

    04/28/2023, 11:23 AM
    expect(result).to be true
    looks nicer than
    expect(result).to be(true)
    though from style perspective 2nd looks better
  • y

    Yury Bushmelev

    04/28/2023, 11:23 AM
    cares about style instead of doing real things 😄
  • v

    VoxBot

    04/28/2023, 11:49 AM
    I started a thing: https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3Abastelfreak+archived%3Afalse+user%3Avoxpupuli+label%3Abackwards-incompatible+%22Drop+Puppet+6+support%22+
    💪🏻 1
  • v

    VoxBot

    04/28/2023, 11:49 AM
    I think it's a good time to drop Puppet 6 now. since we start to see CI issues
  • v

    VoxBot

    04/28/2023, 11:52 AM
    Opinions? :)
  • v

    VoxBot

    04/28/2023, 11:52 AM
    I created PRs for all modules beginning with a; I can continue with all others if noone objects
  • v

    VoxBot

    04/28/2023, 11:52 AM
    11:17 @User Zhenech: shall we start dropping Puppet 6 in our modules?
  • v

    VoxBot

    04/28/2023, 11:52 AM
    11:18 < Zhenech> ewoud, yes
  • v

    VoxBot

    04/28/2023, 11:53 AM
    (today, #theforeman-dev)
  • v

    VoxBot

    04/28/2023, 11:53 AM
    nods
  • v

    VoxBot

    04/28/2023, 11:53 AM
    https://github.com/voxpupuli/beaker-vagrant/pull/73 I needed that after updating to Fedora 38
  • h

    Hugo Haakseth

    04/28/2023, 11:58 AM
    @bastelfreak could you have another look at https://github.com/voxpupuli/puppet-augeasproviders_sysctl/pull/72 ?
    ❤️ 1
  • v

    VoxBot

    04/28/2023, 12:00 PM
    ewoud, your pulpcore-el9 stuff fails because https://github.com/voxpupuli/beaker-hostgenerator/pull/287 is still unreleased
  • v

    VoxBot

    04/28/2023, 12:01 PM
    should we release from master or cut a stable one?
  • v

    VoxBot

    04/28/2023, 12:01 PM
    I recall there are quite some other changes
  • v

    VoxBot

    04/28/2023, 12:02 PM
    you can do the major release if you like
  • v

    VoxBot

    04/28/2023, 12:03 PM
    looks at the clock
1...449450451...642Latest