https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • b

    bastelfreak

    04/25/2023, 9:19 PM
    the german phrase is "danke für nichts GitHub Action"
  • c

    Craig Gumbley

    04/25/2023, 9:19 PM
    lol!!
  • c

    Craig Gumbley

    04/25/2023, 9:19 PM
    (google translate!)
  • b

    bastelfreak

    04/25/2023, 9:19 PM
    haha
  • b

    bastelfreak

    04/25/2023, 9:20 PM
    mhm
  • b

    bastelfreak

    04/25/2023, 9:20 PM
    I can propose an ugly idea that will make ewoud sad
  • c

    Craig Gumbley

    04/25/2023, 9:20 PM
    haha
  • b

    bastelfreak

    04/25/2023, 9:20 PM
    but it's 11pm, so I guess that's fine
  • c

    Craig Gumbley

    04/25/2023, 9:20 PM
    @natemccurdy had a suggestion that seemed reasonable
  • b

    bastelfreak

    04/25/2023, 9:22 PM
    oh which was that?
  • n

    natemccurdy

    04/25/2023, 9:22 PM
    PUPPET_VERSION ~> 7.22
  • c

    Craig Gumbley

    04/25/2023, 9:22 PM
    ^^
  • n

    natemccurdy

    04/25/2023, 9:22 PM
    That'll do, essentially:
    >=7.22, <8.0
  • c

    Craig Gumbley

    04/25/2023, 9:22 PM
    since we know that older Puppets can’t be used, so we just have to be more direct with bundler
  • b

    bastelfreak

    04/25/2023, 9:22 PM
    ah yeah welll that's not that easy to roll out quickly
  • b

    bastelfreak

    04/25/2023, 9:24 PM
    so we usually do
    PUPPET_GEM_VERSION: "~> ${{ matrix.puppet }}.0"
    in CI
  • b

    bastelfreak

    04/25/2023, 9:24 PM
    and luckily the latest puppet 6 release is 6.29, where the minor number is higher than 22, which we need as lowest minor number for puppet 7
  • b

    bastelfreak

    04/25/2023, 9:24 PM
    PUPPET_GEM_VERSION: "~> ${{ matrix.puppet }}.24"
  • b

    bastelfreak

    04/25/2023, 9:24 PM
    (don't tell ewoud)
  • c

    Craig Gumbley

    04/25/2023, 9:25 PM
    😄
  • c

    Craig Gumbley

    04/25/2023, 9:25 PM
    we actually have a similar thing https://github.com/puppetlabs/puppet_litmus/blob/5314169ca1b1c838560e86ab38e4373435fff093/exe/matrix_from_metadata_v2#L148
  • b

    bastelfreak

    04/25/2023, 9:25 PM
    ha!
  • c

    Craig Gumbley

    04/25/2023, 9:25 PM
    though i can target 7 specifically there
  • c

    Craig Gumbley

    04/25/2023, 9:26 PM
    I’m more than happy to lend a hand updating stuff if you need?
  • b

    bastelfreak

    04/25/2023, 9:27 PM
    AHA! https://github.com/voxpupuli/puppet-example/pull/32
  • b

    bastelfreak

    04/25/2023, 9:27 PM
    passed
  • b

    bastelfreak

    04/25/2023, 9:27 PM
    that used my proposed hack: https://github.com/voxpupuli/gha-puppet/pull/30/files
  • b

    bastelfreak

    04/25/2023, 9:28 PM
    neat thing here is: if we merge that all our PRs will pick up that shares github action. We don't need a modulesync
  • b

    bastelfreak

    04/25/2023, 9:28 PM
    I think that's a valid workaround
  • c

    Craig Gumbley

    04/25/2023, 9:34 PM
    Seems legit to me, given the constrains mentioned for puppet 6!
1...436437438...647Latest