https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • n

    natemccurdy

    04/25/2023, 8:37 PM
    @Craig Gumbley What in there specifically?
  • c

    Craig Gumbley

    04/25/2023, 8:37 PM
    Whoops
  • c

    Craig Gumbley

    04/25/2023, 8:38 PM
    https://github.com/puppetlabs/cat-github-actions/blob/7caf235d9308330cb8e46e2e10f0dd58cc6b5592/.github/workflows/module_ci.yml#L50
  • c

    Craig Gumbley

    04/25/2023, 8:39 PM
    Although Tim might have already done that.. in the PR
  • s

    Slackbot

    04/25/2023, 8:39 PM
    This message was deleted.
    v
    n
    b
    • 4
    • 3
  • n

    natemccurdy

    04/25/2023, 8:40 PM
    PUPPET_GEM_VERSION: "~> 7.0"
    But it's pulling in 7.21.0.
  • n

    natemccurdy

    04/25/2023, 8:40 PM
    Instead of 7.23.0
  • b

    bastelfreak

    04/25/2023, 8:40 PM
    those are different jobs
  • b

    bastelfreak

    04/25/2023, 8:41 PM
    I updated the
    setup_matrix
    job to pull in puppet
    7.x
    . Previously we only defined the puppet version in the Gemfile as:
    Copy code
    puppetversion = ENV['PUPPET_GEM_VERSION'] || '>= 6.0'
    gem 'puppet', puppetversion, :require => false, :groups => [:test]
  • b

    bastelfreak

    04/25/2023, 8:41 PM
    now what's failing are the unit tests for the
    unit
    job: https://github.com/voxpupuli/gha-puppet/pull/30/files#diff-a5f1ef1c4e2526c1092b3d50254581c35462653f2b0f467628f6c36aeea60becL80
  • b

    bastelfreak

    04/25/2023, 8:42 PM
    because it doesn't pull in the latest puppet 7 but 7.21, which allows a newer ruby-concurrent, which doesn't work well with the used ruby/puppet version. but that worked in the past (like 3 hours ago)
  • c

    Craig Gumbley

    04/25/2023, 8:44 PM
    I’ll pull your branch in a sec
  • b

    bastelfreak

    04/25/2023, 8:46 PM
    https://github.com/voxpupuli/puppet_metadata/pull/75
  • c

    Craig Gumbley

    04/25/2023, 8:57 PM
    @bastelfreak do you mind if i clear the workflow cache and re-kick puppet-example/32?
  • b

    bastelfreak

    04/25/2023, 8:57 PM
    na, just go on
  • c

    Craig Gumbley

    04/25/2023, 8:59 PM
    I’m hoping it’s just some bundler magic.. because it appears to pull 7.24 locally in a couple of test envs
  • b

    bastelfreak

    04/25/2023, 9:00 PM
    mhm it doesn't make sense. why does it fail now
  • c

    Craig Gumbley

    04/25/2023, 9:02 PM
    https://github.com/puppetlabs/puppetlabs-motd/actions/runs/4792211424/jobs/8545256197
  • c

    Craig Gumbley

    04/25/2023, 9:02 PM
    thinking party
  • b

    bastelfreak

    04/25/2023, 9:02 PM
    I can also reproduce that locally
  • b

    bastelfreak

    04/25/2023, 9:03 PM
    in theory, direct deps (as in declared in a gemfile) have high prio over transitive deps
  • b

    bastelfreak

    04/25/2023, 9:03 PM
    and we declare puppet, not ruby-concurrent. so puppet should have a higher prio and we should get 7.24
  • b

    bastelfreak

    04/25/2023, 9:03 PM
    and that worked until a few hours ago
  • b

    bastelfreak

    04/25/2023, 9:04 PM
    we could add ruby-concurreny to our gemfile and pin < 1.2 but that requires a modulesync
  • b

    bastelfreak

    04/25/2023, 9:05 PM
    I could hack puppet_metadata so we depend on puppet ~> 7.24
  • c

    Craig Gumbley

    04/25/2023, 9:07 PM
    hmm
  • n

    natemccurdy

    04/25/2023, 9:07 PM
    ~> 7.22
    was the only way I found to get something higher than
    7.21
    and below
    8
    .
  • b

    bastelfreak

    04/25/2023, 9:07 PM
    but I would like to understand why it fails
  • b

    bastelfreak

    04/25/2023, 9:08 PM
    it feels like a bundler bug
  • c

    Craig Gumbley

    04/25/2023, 9:08 PM
    what version of bundler is everyone running locally (and what OS)
1...434435436...647Latest