https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • y
    looks like I found a bug while reading some random beaker provider’s code: https://github.com/voxpupuli/beaker-google/blob/main/lib/beaker/hypervisor/google_compute.rb#L20
  • y
    this line should be 
    public_keyfile
    I believe
  • y
    well.. maybe not that easy.. but something is wrong there.. 🤔
  • y
    maybe just naming issue though..
  • b
    possible that nobody uses that plugin at the moment
  • y
    well.. I guess as long as 
    BEAKER_gce_ssh_public_key
    points to private key actually it should be fine
  • y
    so looks like a documentation issue
  • b
    so volunteers to drop Puppet 6 from our metadata.json?
  • b
    I think we should also update rubocop, but that should be another PR
  • a
    Could you leave puppet_certificate alone until I get at least 1 release out ‘as is’? (and please keep pinging me throughout the week!)
  • b
    yeah sure
  • b
    in theory we could also release all modules with unreleased enhancements/bugfixes, then drop puppet 6, release again. But that is a huge amount of work
  • b
    and we need to check if we can use voxpupuli-rubocop for our modules as well
  • b
    well, should check
  • b
    @Alex Fisher have you used puppet_certificate? how bad is the idea to use that to mansge the puppetserver cert?
  • a
    BTW, you realise puppetserver 7 is only ruby 2.6 compatible right?
  • a
    So make sure you don’t go beyond that in the module rubocop rules or you will break stuff.
  • b
    Puppetlabs lints for Ruby 2.7 on their modules
  • y
    PDK default is 2.7 in rubocop rules IIRC
  • a
    IMO that's a mistake then! @Craig Gumbley ?
  • b
    during the puppet 6 days, they also linted for the ruby version in the agent, not the older puppetserver
  • b
    (so do we)
  • a
    And I remember the bug reports… The only extra recommendations rubocop will give are the ones guaranteed to break stuff in functions and types.
  • s
    This message was deleted.
    c
    a
    • 3
    • 9
  • a
  • a
    They do run the spec tests against 2.7 which is perhaps a bit risky (and better options might be a bit limited), but at least the code rubocop has looked at is valid Ruby 2.5.
  • a
    You’re going to make rubocop deliberately use ruby 2.7 compatible only code if it prefers the new style and this will break modules for puppetserver 7 users (and 8 isn’t out yet)
  • a
    It was more annoying with puppetserver 5? as you had a choice of two jruby implementations leading to issues like this https://github.com/voxpupuli/puppet-firewalld/issues/250
  • y
    Ah.. so I was wrong about the ruby version in pdk..
  • b
1...424425426...647Latest