Here is the release PR for genomeassembler v2 <git...
# release-review-trading
n
Here is the release PR for genomeassembler v2 github.com/nf-core/genomeassembler/pull/218 ! Its kinda large
approved with comments 1
d
Happy to review that in return for github.com/nf-core/phyloplace/pull/88
👍 1
✅ 1
The final test is running.
I started to look at yours but you have a test failing (as I'm sure you know). This is what my Claude says about it: """ The blocker: conda | 25.10.4 | 2/2 fails (the pinned-version leg that gates merge — latest-everything is allowed to fail and isn't the issue here). Root cause: the QUAST process crashes with ModuleNotFoundError: No module named 'distutils'. QUAST 5.3.0's code still does from distutils.version import LooseVersion, and distutils was removed from the Python standard library in 3.12+. The module's environment.yml (bioconda::quast=5.3.0, no python pin) let conda resolve Python 3.13, which doesn't have it. This isn't specific to genomeassembler — it's an already-known, currently-open upstream bug in nf-core/modules' vendored quast module: - nf-core/modules#12903 — "QUAST: test fails with conda" - nf-core/modules#12905 — "pin python 3.11 in quast env" Fastest unblock, if he doesn't want to wait on upstream: patch the module locally — nf-core modules patch quast, add a python<3.12 (or =3.11) pin to modules/nf-core/quast/environment.yml, regenerate the patch. That's a one-line env fix, no code change needed elsewhere. """
Ping me when it's ready for a full review.
n
This PR is already upstream, if you have second (it is +1 line in environment.yml): github.com/nf-core/modules/pull/12905
d
Done, but I notice you didn't patch the module.
n
The PR is in modules
d
I see 🙂
n
Here is the PR to update the module in the pipeline github.com/nf-core/genomeassembler/pull/219
✅ 1
Thanks!
d
Just a tiny suggestion in two places on yours.
🙌 1
n
Thanks! I have some suggestions on yours, but they are all rather minor
👍 1