Can I get a second for phyloplace 2.2.0: <github.c...
# release-review-tradingd
Daniel Lundin
09/08/2026, 12:28 PMCan I get a second for phyloplace 2.2.0: github.com/nf-core/phyloplace/pull/88
👀 1
approved with comments 1
Daniel Lundin
09/10/2026, 1:20 PM@piplus2 You seem to be working towards a release. I'd be happy to look at that if have a look at this. Has already been reviewed and updated after that.
p
piplus2
09/10/2026, 1:22 PM@Daniel Lundin yes, trying to refactor all the old code. No worries, I'll have a look. I'll ask help to Claude, if that's ok for you.
d
Daniel Lundin
09/10/2026, 1:22 PMI take that as a quality assurance -- my reviews after I started using Claude has improved a lot.
👍 1
p
piplus2
09/10/2026, 5:39 PM@Daniel Lundin just added my comments, tiny stuff
d
Daniel Lundin
09/10/2026, 6:55 PMGrazie! 🙂 Having a look right now. When you have time, I made updates to github.com/nf-core/metatdenovo/pull/504
approved with comments 1
p
piplus2
09/10/2026, 8:03 PMapproved with one small thing left
d
Daniel Lundin
09/10/2026, 8:50 PMThanks
Daniel Lundin
09/11/2026, 6:29 AMGood morning! What I was thinking of reminding you was another PR, not the release phyloplace (your comment there was indeed very valuable, so thanks for that) but the still not approved metatdenovo: github.com/nf-core/metatdenovo/pull/504. We did updates to this and I believe I requested a re-review, but I might have forgotten. (This PR turned out to be far more complex than I thought it could be.)
👀 1
📝 1
p
piplus2
09/11/2026, 6:57 AMHi! Ok I'll have a look in a bit
2 Views