Hi <!subteam^S016E36N7TQ>! We are looking for a se...
# release-review-trading
d
Hi <!subteam^S016E36N7TQ>! We are looking for a second review to make the first release of
datasync
. Would anyone be able to take a look at it? github.com/nf-core/datasync/pull/82 Thank you!
p
I made a pseudo-PR for first release review: github.com/nf-core/datasync/pull/88
👍 1
By basing the PR on the latest template, it halves the code diff and makes first-release review much easier
First first-release pipeline review in quite a while, so apologies if I'm rusty! 😆
Really didn't find much to comment on, great job all!
d
Thank you!!
p
@Delfina Terradas you've marked a bunch of my review comments as resolved, but without any comment of your own or commits that update the code that I can see. Is this intentional?
d
Hi @Phil Ewels! Sorry, I was working on implementing your suggestions but never linked the PR 🫣 I have now attached the link to the PR and can tag you when it is done. Thank you for your feedback!
p
Nice, thanks!