https://htmx.org logo
Join Discord
Powered by
# htmx-general
  • e

    echoing-dress-67727

    02/21/2023, 9:00 PM
    Actually, no. First let me ask this: why is this indented twice? https://github.com/bigskysoftware/htmx/blob/master/src/htmx.js#L14 It shouldn't be. That's the main cause of the big diff there
  • m

    mysterious-car-3675

    02/21/2023, 9:05 PM
    cause prettier is tool, tool is bad. 😛
  • e

    echoing-dress-67727

    02/21/2023, 9:05 PM
    https://grugbrain.dev/#grug-on-tools > grug love tool > ... > grug say never be not improving tooling
  • m

    mysterious-car-3675

    02/21/2023, 9:07 PM
    I believe you just Ace Attorney'd that
  • e

    echoing-dress-67727

    02/21/2023, 9:09 PM
    Simplified that PR even more: https://github.com/bigskysoftware/htmx/pull/1263
  • m

    mysterious-car-3675

    02/21/2023, 9:10 PM
    also you can use .gitattribute linguist to remove generated code from diffs
  • e

    echoing-dress-67727

    02/21/2023, 9:12 PM
    Details about that: https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github
  • r

    refined-waiter-90422

    02/21/2023, 9:13 PM
    Cool that looks good. Also tested, works as the old one did. I think this is a good change if it helps the node folks.
  • e

    echoing-dress-67727

    02/21/2023, 9:14 PM
    Not node folks. Modern browser folks
  • e

    echoing-dress-67727

    02/21/2023, 9:14 PM
    But thanks for the review and suggestion on simplifying it! Anything to get it merged sooner 😄
  • e

    echoing-dress-67727

    02/21/2023, 9:15 PM
    I'm hoping to get node OUT of my app if possible 😁
  • e

    echoing-dress-67727

    02/21/2023, 9:15 PM
    Less JS = simpler. That's why I started using HTMX to begin with
  • r

    refined-waiter-90422

    02/21/2023, 9:24 PM
    ESM in its current form is not perfect- the new requirement of a dedicated server to run your module is a feature removal. The standard may change in the future, though.
  • e

    echoing-dress-67727

    02/21/2023, 9:25 PM
    > new requirement of a dedicated server I'm not sure what you mean by that
  • r

    refined-waiter-90422

    02/21/2023, 9:26 PM
    Try loading an ESM on a local html file without it throwing a CORS error.
  • e

    echoing-dress-67727

    02/21/2023, 9:28 PM
    I still don't understand. Got an example source code?
  • r

    refined-waiter-90422

    02/21/2023, 9:31 PM
    I'll pull out my example from last month
  • s

    stocky-school-57923

    02/21/2023, 9:33 PM
    Anyone know how i can trigger an hx-request when enter is clicked? Tried all sorts of variations of hx-trigger="click[enter]"
  • r

    refined-waiter-90422

    02/21/2023, 9:33 PM
    Copy code
    html
    <html>
      <head>
        <script type="module" src="test.js"></script>
      </head>
      <body>
      </body>
    </html>
    Copy code
    js
    // test.js
    export function test () {
      alert("hello");
    }
    e
    • 2
    • 8
  • m

    mysterious-toddler-20573

    02/21/2023, 9:45 PM
    what do you mean "enter" is clicked?
  • m

    mysterious-toddler-20573

    02/21/2023, 9:45 PM
    do you mean "enter is typed"?
  • m

    mysterious-toddler-20573

    02/21/2023, 9:47 PM
    https://codepen.io/1cg/pen/ZEjOLjb?editors=1001
  • m

    mysterious-toddler-20573

    02/21/2023, 9:47 PM
    if so
  • s

    stocky-school-57923

    02/21/2023, 9:47 PM
    Its a text input. I want user to type message, then hx-request fired on enter-click
  • m

    mysterious-toddler-20573

    02/21/2023, 9:48 PM
    what does "enter click" mean?
  • m

    mysterious-toddler-20573

    02/21/2023, 9:48 PM
    this example will issue a request when
    enter
    is typed
  • m

    mysterious-toddler-20573

    02/21/2023, 9:48 PM
    but I don't know what
    enter click
    means
  • s

    stocky-school-57923

    02/21/2023, 9:48 PM
    This example is what i mean 🙂
  • m

    mysterious-toddler-20573

    02/21/2023, 9:48 PM
    roger
  • s

    stocky-school-57923

    02/21/2023, 9:49 PM
    Thank you very much, lifesafer!
1...103410351036...1146Latest