https://htmx.org logo
Join Discord
Powered by
# htmx-general
  • m

    mysterious-toddler-20573

    02/21/2023, 8:15 PM
    could have been worse, I tried to learn from this as well, but just couldn't figure it out:
  • m

    mysterious-toddler-20573

    02/21/2023, 8:15 PM
    OKOK< OK
  • m

    mysterious-toddler-20573

    02/21/2023, 8:15 PM
    OK
  • e

    echoing-dress-67727

    02/21/2023, 8:17 PM
    This was my intro to programming. A supervisor at the time asked "you interested in coding?" and when I nodded, she plopped a huge text book in front of me and said to get to reading lol
  • m

    mysterious-car-3675

    02/21/2023, 8:18 PM
    first book that had an impression was https://openlibrary.org/books/OL419484M/Michael_Abrash's_graphics_programming_black_book i met him 10 years later at GDC and thanked him
  • e

    echoing-dress-67727

    02/21/2023, 8:18 PM
    And then after that, I dug into a huge spaghetti-code mess of a Java app. I think I might've been a bit traumatized by that. πŸ˜‚
  • m

    mysterious-car-3675

    02/21/2023, 8:19 PM
    IThinkIMightveBeenABitTraumatizedByThatFactoryManagerBuilder
  • e

    echoing-dress-67727

    02/21/2023, 8:20 PM
    Not to mention the raw SQL strings that were written out by hand. shudders
  • s

    some-airline-73512

    02/21/2023, 8:21 PM
    I’m doing zero tests, but it’s okay for mvp that I’m building I guess
  • m

    mysterious-car-3675

    02/21/2023, 8:22 PM
    tests matter once an API is solidified
  • m

    mysterious-toddler-20573

    02/21/2023, 8:23 PM
    https://grugbrain.dev/#grug-on-testing
  • e

    echoing-dress-67727

    02/21/2023, 8:23 PM
    https://github.com/bigskysoftware/htmx/pull/1263
  • e

    echoing-dress-67727

    02/21/2023, 8:24 PM
    > grug once again catch grug slowly reaching for club, but grug stay calm 🀣 🀣
  • r

    refined-waiter-90422

    02/21/2023, 8:27 PM
    Why is your diff such a giant mess?
  • e

    echoing-dress-67727

    02/21/2023, 8:27 PM
    Because it's making a huge change to the source file, by unindenting everything one level
  • e

    echoing-dress-67727

    02/21/2023, 8:28 PM
    This helps
  • e

    echoing-dress-67727

    02/21/2023, 8:31 PM
    I'll add a description to explain what's happening there
  • r

    refined-waiter-90422

    02/21/2023, 8:34 PM
    I think whitespace is like 90% of all external contributions at this point. πŸ˜‘
  • e

    echoing-dress-67727

    02/21/2023, 8:36 PM
    The new indentation is consistent with the output from other UMD outputs from build systems, which most NPM modules use.
  • e

    echoing-dress-67727

    02/21/2023, 8:36 PM
    Mainly, I didn't feel like mucking with this:
    Copy code
    (function (global, factory) {
        typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
        typeof define === 'function' && define.amd ? define(factory) :
        (global = typeof globalThis !== 'undefined' ? globalThis : global || self, global.htmx = factory());
    })(this, (function () {
  • r

    refined-waiter-90422

    02/21/2023, 8:43 PM
    Sure. It just can suck for people actually reading the code and using htmx because all the per-line git history is replaced with
    Derek: I did a whitespace change lol
  • e

    echoing-dress-67727

    02/21/2023, 8:43 PM
    Yeah, makes sense. There's a tool in git for that, but it's not used much
  • e

    echoing-dress-67727

    02/21/2023, 8:44 PM
    .git-blame-ignore-revs
  • e

    echoing-dress-67727

    02/21/2023, 8:44 PM
    You put commit shas in there, and they get ignored in the blame. At least locally, not sure about github
  • e

    echoing-dress-67727

    02/21/2023, 8:52 PM
    omg, this grugbrain page πŸ˜‚ > Microservices > > grug wonder why big brain take hardest problem, factoring system correctly, and introduce network call too > > seem very confusing to grug Have wiser words ever been muttered?
  • r

    refined-waiter-90422

    02/21/2023, 8:56 PM
    Sooo.. whats the hidden catch to moving to UMD? Are we gonna lose our server-free ability to run htmx or are we in the clear?
  • m

    mysterious-car-3675

    02/21/2023, 8:57 PM
    you lose nothing as an end user, you gain extra options for how to run
  • e

    echoing-dress-67727

    02/21/2023, 8:58 PM
    The code changed slightly, but it's almost identical to what was there before, with this addition:
    typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory()
  • e

    echoing-dress-67727

    02/21/2023, 8:58 PM
    So if
    module
    is available (which is true in ESM), then it does
    module.exports = factory()
  • e

    echoing-dress-67727

    02/21/2023, 8:59 PM
    Let me see if I can simplify the diff
1...103310341035...1146Latest