Haxe

Running react-router-dom version 4.3.1 with git externs

Okay defo giving up now, this error is back 😂

The snake oil i've figured out to remove annoying diagnostics error

WELL, the compiled code still errors so i'm not sure if this is me bypassing diagnostics and there's actually an issue or something else :D

Can confirm diagnostics snake oil is indeed legit

Funnily enough to be able to get the diagnostics to go away I can ***only*** switch to `Route.hx`

Okay i've also figured out a way to bypass dumb snake oil technique

<@456226577798135808> mui is missing `TableContainer` I would add it but I have no idea how to structure the externs with this 😂

Sorry I wasn't available this week-end, are all react-router issues solved?

Yeah TableContainer is 4.8.0, externs are available for 4.7.2 only atm

> Either way, is the proper way to utilise `wrap` by adding `@:wrap(react.router.ReactRouter.withRouter)` to the Component and then adding `history` as prop?

Usually I do this:

```
import react.router.ReactRouter;
import react.router.Route.RouteRenderProps;

private typedef Props = {
    > PublicProps,
    > RouteRenderProps,
}

private typedef PublicProps = {
    // ...
}

@:publicProps(PublicProps)
@:wrap(ReactRouter.withRouter)
class MyComponent extends ReactComponentOfProps<Props> { /* ... */ }

```

Did you get `You should not use <Route> or withRouter() outside a <Router>` because you were missing a router?

Damn I can't find v4 doc, <Route> seems to have changed somehow in v5

I don't have this issue because for things like that I usually do `<Route component={SystemLogs} ... />`
Anyway, this should work with latest react-router-4 git

I didn't wrap the ReactDom call to `<$App>` in a router

I had only wrapped the App component specifically

I figured that out by checking the other react router libs readme

And the way I got past that weird diagnostics issue was just provide it with the component prop rather than making it a child