Rory Fearon
05/08/2026, 1:04 PMPylon
05/08/2026, 1:04 PMRory Fearon
05/08/2026, 1:05 PMPylon
05/08/2026, 2:37 PMchecks are stalling
Does this mean that eventually the correct status appears in graphite? Is this for the buildkite or the
type-check ? both? we should be relying on github webhook to update us on the status of the checks.
being treated as blocking in gaphite
How are you handling check requirements? classic branch protection rules (BPRs)? rulesets?
github knows are not PR blocking are
How are you validating? github showing mergable? is this for everyone or only repo/ org admins maybe? Do you have bypass actors? Are you using githubs concurrency control at all?
Ben McMahon
05/08/2026, 2:47 PMDoes this mean that eventually the correct status appears in graphite? Is this for the buildkite or theIt was a required check that was never triggered. Graphite seemed to believe it was in progress (although we mostly blame github for this, it seems like a long standing UX issue)? both? we should be relying on github webhook to update us on the status of the checks.type-check
How are you handling check requirements? classic branch protection rules (BPRs)? rulesets?Basic branch protection yes
How are you validating? github showing mergable? is this for everyone or only repo/ org admins maybe? Do you have bypass actors?Github was showing mergeable but graphite seemed to want things that ran on the PR at one point to run again (e.g. we use cursor, it had reviewed, we'd fixed the cursor review issues, and not bothered to re-run it). This could be been conflated with the other missing required check issue.
Are you using githubs concurrency control at all?Yes, for the required type-check we're using a per-PR check, so a new push should cancel and retrigger on the HEAD
Pylon
05/08/2026, 3:08 PMIt was a required check that was never triggered
This, yea, there is not much we can do here. We rely on the check suite to successfully trigger based on actions that happen to the state of the PR.
we'd fixed the cursor review issues, and not bothered to re-run it
This one im curious about. Shouldnt it run on a new version of the PR ie new SHA via commit or amendment? Otherwise im not sure there is anything wrong with your settup. I would expect BPRs to work consistently well, and new versions of the PR to trigger new CI runs. We have seen some scenarios where the check is passing in github and showing as pending in graphite which often tracks to a race condition in the github concurrency setting but that doesnt seem like the issue you are facing.
Ben McMahon
05/08/2026, 4:35 PMPylon
05/08/2026, 6:20 PM