https://discord.cloudflare.com logo
Join Discord
Powered by
# workers-discussions
  • j
    mapRequestToAsset
    doesn't fire for assets that exist in the 
    ASSET_MANIFEST
    - they're always served directly from KV. In an older version of 
    kv-asset-handler
    , this used to work as per https://github.com/cloudflare/kv-asset-handler/blob/ce0229fe54e38728b2d7796646e20a05ea23b6d1/src/index.ts#L98, which always used 
    mapRequestToAsset
  • j
    Unless I'm misunderstanding what you're saying? As per https://github.com/cloudflare/kv-asset-handler/blob/3228cd78de1f4f61d74cecb13a3b19054d67d501/src/index.ts#L104-L110 though, this function is never fired if the asset exists in the manifest. So if I have a 
    jpg
    , 
    webp
    and 
    avif
    in the manifest, and someone requests the 
    jpg
    , there's no simple way to programatically serve the 
    avif
    (such as in a CSS 
    background-image
    ), as far as I can tell.
  • i
    Oh, yeah you are right... if it only allowed to pass in only the request. They need the full event for a waitUntil, but couldn't you simply copy the event and modify the URL? It's not the best, but might work.
  • j
    Is there an API I'm not aware of to clone and modify a 
    FetchEvent
    like that? Trying to reconstruct a 
    FetchEvent
    myself to hackily work around this throws a 
    Illegal constructor
    error 😦
  • i
    Never tried and never sure it even works... if you are on Business and up you could use the Image Resizer from CF.
  • j
    Yeah that's probably an option with 
    format=auto
    and 
    format=avif
    . I'd prefer to statically do this though on my very static Workers sites,. Hopefully there'll be a resolution on this issue. This definitely used to be possible in older versions of 
    kv-asset-handler
    , but was originally changed in https://github.com/cloudflare/kv-asset-handler/commit/c97b8ddf118b8711bc1cc9408461a1c47a1843be it seems.
  • j
    I've no idea on the full scope of why 
    mapRequestToAsset
    couldn't be called on every request if it's explicitly passed into 
    options
    - it would seem logical to me to allow this.
  • i
    Yeah, this.
  • i
    Maybe @User or @User know who to ask for this. Or maybe we can even open a pull request ourselves.
  • j
    I'd happily create a PR and even add some tests for this if it makes sense. I just want to make sure I understand the impact. From what I can tell, it should be pretty simple to tweak the 
    getAssetFromKV
    function, switch up the 
    Object.assign
    at the top for defaults, handling `mapRequestToAsset`'s default more manually. And then below when assigning 
    requestKey
    , check if 
    options.getAssetFromKV
    was explicitly passed in (not from default), and if so use that, else do the existing behaviour.
  • r
    for 5,600,000,000 requests per/month you said "Those are 25k+$/month," - isn't at $0.5 per 1m = ~2.8k $/m
  • i
    Oh, yeah! You are totally right... I did that in my head and used the 5 without diving by ten. The rest of the suggestion still stands, contact sales.
  • c
    @User Is there a way to bypass the domain registratino check on cloudflare?
  • c
    I just registered a name and want to get it provisioned by cloudflare isn't seeing it yet
  • a
    You mean using the Cloudflare Registrar?
  • c
    It was registered externally
  • c
    it's being managed for a customer, not my name
  • c
    paste.cx
  • c
    it even points to my cloudflare nameservers
  • c
    dara and micah
  • c
    Copy code
    Domain Name: paste.cx
Registry Domain ID: 1862755-CoCCA
Registry WHOIS Server:: whois.coccaregistry.org
Updated Date: 2020-12-07T16:11:19.712Z
Creation Date: 2020-12-07T16:07:54.36Z
Registry Expiry Date: 2021-12-07T16:07:54.99Z
Registrar Registration Expiration Date: 2021-12-07T16:07:54.99Z
  • a
  • c
    No I'm not transfering it
  • c
    I just mean adding it to my cloudflare account for dns and cdn
  • c
  • a
    o gotcha, sometimes that can take up to 48 hours
  • i
    It's been just registered, it needs to propagate. Give it a couple hours at least.
  • i
    Also, never point domains to Cloudflare nameservers prior to adding them, it will cause you issues, especially with some registrars and some TLDs.
  • c
    Wait really? I've never had issues before doing that
  • i
    Yeah, sometimes Cloudflare's systems recognise it as trying to hijack it, causing them to issue different nameservers (there are no user NS, those are always per domain, which tend to stay the same unless something changes). Some registrars then require the new ones to respond with the correct ones, but Cloudflare won't since it sees the old ones and you need to ask support. Seen it soooo many times in the Community.
1...141516...2509Latest