https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • c

    cconrad

    12/22/2021, 7:53 PM
    I opened a couple of PRs with typos I found while browsing the wiki. I'm new to contributing to open-source repos - maybe it would be easier to review if I collected several commits into one PR? Is this at all helpful or are the docs under review/update anyway?
    s
    • 2
    • 6
  • s

    SeriousBug

    12/22/2021, 7:56 PM
    Putting them all in a single PR would be easier both for you and the reviewer I'd guess. But if you already have them open, that's absolutely fine!
  • r

    rlh1994

    12/22/2021, 7:58 PM
    Fixing typos is 98% of my open source contributions πŸ˜… ever
  • s

    SeriousBug

    12/23/2021, 9:17 AM
    Hey, is the preview in plugin using
    dendron-next-server
    or
    dendron-plugin-views
    ? Both of them have code for note previews
  • k

    kevins8

    12/23/2021, 3:33 PM
    plugin views
  • k

    kevins8

    12/23/2021, 9:55 PM
    left a comment in the PR
  • s

    ScriptAutomate

    12/23/2021, 11:09 PM
    Dendron Wiki PRs and Capitalization
  • a

    amar

    12/26/2021, 9:52 AM
    Her folks, if I ported al the scss stuff to less (such that it's compat with ant.design) would that be worthwhile? This will hopefully make it easier to implement custom theming later. My current custom them depends on modifying main.scss
  • a

    amar

    12/26/2021, 9:54 AM
    Alternatively, passing variables between the two via vanilla CSS, rather than hardcoding them in there
  • k

    kevins8

    12/26/2021, 3:15 PM
    since everything compiles down to css, i wouldn’t worry about porting the scss . i’m planning on fixing the customHeader ordering so that you should just be able to add regular css
  • r

    rlh1994

    12/28/2021, 8:30 PM
    FYI quite a few of the links in the dendron PR template don't go anywhere anymore, so it might be hard for new contributors to make sure it's all followed (I'm changing a single string, so managed to avoid the need for all the test docs πŸ˜… )
  • u

    [root@Cruz] $~

    12/28/2021, 8:31 PM
    Hello I would like to submit a formal request for knowledge pls
  • k

    kevins8

    12/28/2021, 9:19 PM
    thanks for the tip. will be updating that today!
  • k

    kevins8

    12/28/2021, 9:19 PM
    what kind of knowledge would you like?
  • u

    [root@Cruz] $~

    12/28/2021, 9:20 PM
    I would love to know how to make a custom template for my work notes. I'm working on downloading the template seeds to play around in there, but the download is hanging.
  • u

    [root@Cruz] $~

    12/28/2021, 9:23 PM
    Is it cool to hit you with a DM? I got this error trying to add the wiki seed.
    s
    • 2
    • 2
  • s

    ScriptAutomate

    12/29/2021, 1:03 AM
    Troubleshooting seed imports
  • s

    SeriousBug

    12/29/2021, 9:52 AM
    Hey folks. I wrote an RFC for linking and embedding files into your notes. A bit of this has already been implemented, but I would love to get some feedback from the community before we continue with the rest: https://docs.dendron.so/notes/WCZ1LzhM07Om3KFPERk6l/
  • t

    Tika

    12/29/2021, 9:57 AM
    Is there a discussion for this somewhere?
  • s

    SeriousBug

    12/29/2021, 9:58 AM
    Yes, it's linked at the end of that page
  • k

    kevins8

    12/29/2021, 6:13 PM
    heads up that there's now a PR for the PR template -> https://github.com/dendronhq/dendron/pull/2011
  • s

    SeriousBug

    01/03/2022, 7:17 AM
    Is there something I can check in
    dendron-cli
    to make sure code I'm adding only works in CLI and not if it's imported by the plugin? Any environment variables I can check or anything?
  • k

    kevins8

    01/03/2022, 5:37 PM
    not yet, can you elaborate on the use case?
  • k

    kevins8

    01/03/2022, 5:57 PM
    ah, nvm, i see on https://github.com/dendronhq/dendron/pull/2035/files for this, can we explicitly pass in an option to disable it when running from the plugin?
  • l

    lukecarrier

    01/06/2022, 6:13 PM
    πŸ‘‹ I threw together a script[1] to run between
    dendron publish build
    and
    cd .next/ && npm run export
    that automatically converts any Draw.io diagrams referenced as images to SVG, and rewrites the links. Would this be an interesting contribution to get inside Dendron itself? I don't see any RFCs around support for non-note (non-text?) nodes, but I wonder if there are similar use cases this might address? [1]: https://gist.github.com/LukeCarrier/646713b8f666bc6351171f2fccef4054
    k
    s
    t
    • 4
    • 8
  • k

    kevins8

    01/06/2022, 6:53 PM
    publish-draw-io
  • l

    lukecarrier

    01/07/2022, 12:06 AM
    Is there anything blocking us making better use of build caches during publishing? There seem to be a few low hanging fruit I could pick up if it’d help: - If the .next dir already exists on init, making sure our remote exists and issuing a fetch and reset rather than removing it to clone the repo again - Keeping the nextjs cache dirs around to speed up generation - Updating our Netlify and GH workflows Since moving to publishing v3 and publishing daily I’ve been burning my free build credits in the first week πŸ˜…
    k
    • 2
    • 9
  • s

    ScriptAutomate

    01/07/2022, 12:08 AM
    Would love to see those optimizations if able. I've been wiping those dirs and cache by default due to issues caused, that's why the publishing templates wipe things out, too
  • c

    codeluggage

    01/09/2022, 8:05 AM
    Are there any guidelines, steps or rules for contributing to the docs? Came across a broken link and figured I'd try the "click all the default things" way to submitting a fix. Noticed that the repo was basically just a vault with no
    README.md
    (ha!) nor PR template. As such I can imagine signing the CLA (https://gist.github.com/kevinslin/bf139201df65f0ae6c7b13fd01330f9d) may be missed for new contributors - though I suspect it is very unlikely it (nor anything else) would slip your mind, Kevin. https://github.com/dendronhq/dendron-docs/pull/8
  • c

    codeluggage

    01/09/2022, 8:09 AM
    On the topic, what does
    #repot
    on this page mean? https://github.com/dendronhq/dendron-docs/blob/main/vault/rfc.md?plain=1#L11
1...878889...108Latest