you already call them assets as in assets/images ?

Sure, but this is not really for images or assets. We want to be able to link to code files, config files etc.

why cannot you have asset/code ? if it is bits of the world glued by markdown then you only have glue (md) and assets everything else, no?

That makes sense, but do you think it would be okay with native workspaces where it's files that are part of a bigger project?

ah. well. this is the problem with any human taxonomy, they are impositions and not representations. so, none will fit the reality properly. the only criterion for success is their pragmatic usefulness. so, i shall retire here as i am not using those native workspaces and do not know what they feel like in practice. 🙂

How about "non-markdown files"? It does feel a little weird to call something by what it isn't. But maybe that would be the clearest term here? @SeriousBug

Maybe 'native files' as in 'files native to the workspace' ? Might be too oblique. Seems appropriate to the feature though

Local publishing question... Images aren't rendering when I

npx dendron publish dev

. The

src

attribute is getting prefixed with

/david-dendron

(the workspace name), when it should not be (red arrow in screenshot). Removing that from the URL shows the image (green arrow). Any ideas?

Images not appearing in published sites?

Re: Issue #1803,

Redirect note.html to note

, how do we feel about a solution like this in

404.js

? @User https://github.com/dendronhq/dendron/issues/1803

// pages/404.js

// Don't run `window` functions on node processes that don't have a window yet.
const isServer = () => typeof window === 'undefined'

export default function Custom404() {
  if (!isServer()) {
    const currentUrl = window.location.toString();
    const endsWithHtml = /(.+)\/notes\/(\w+).html/;
    const urlParts = currentUrl.match(endsWithHtml);
    if (urlParts) {
      console.log(currentUrl, urlParts)
      const server = urlParts[1];
      const noteId = urlParts[2];
      const newUrl = `${server}/notes/${noteId}`
      window.location = newUrl
    }
    
  }
  return <h1>404 - Move along. Nothing to see here.</h1>;
}

This is tested and works on the local dev server. The last part, the return text is just a joke for diagnostics. I'll add full comments if everyone likes this solution. Thanks in advance.

looks good

Great. Will integrate into a PR first thing tomorrow. 🙂

A couple of other questions on #1803... @User

rip, I didn't get a @mention on the 0.72 announcement 😞

just updated!

oh

thank you! 🙂

thanks for catching!

Is anyone elses workflow broken in the latest VSCode Insiders? Renaming symbols stopped working for me.

is that still the case when you disable all extensions?

(i develop using regular vscode and use dendron with vscode insider so haven't run into this yet😅 )

Huh nevermind, there must be something wrong with the package I'm using. It says it's

1.56

and not something like

1.64

.

https://github.com/dendronhq/dendron/runs/4530572552?check_suite_focus=true

error An unexpected error occurred: "Failed to replace env in config: ${NPM_TOKEN}".

I saw the same issue locally but resolved by removing

.npmrc

. Is there something I need to do to get the tests to run on git?

I keep getting prompts for the survey while trying to run plugin test suite. Can I do something to disable it for testing?

hmm, i thought I disabled this already. @User can you comment? ☝️

which survey is it prompting? I haven't run into this myself personally.

Hi, I'm trying my chances with contribution, how to run full tests? Seems links are missing in the docs Trying something really small https://github.com/dendronhq/dendron/pull/1961 I've debuged it and tested manually with many different links, Don't hesitate to roast me 🙂 First time open source contributing - also I have like not a full year of experience with node and TypeScript, now working with different stack I'm just trying not to forget the knowledge.

tests docs here -> https://docs.dendron.so/notes/99q7A73uGmCwu2KvSHZro/ 🙂

we all have to start honored that you choose us 🌱