I've had it happen due to my domain configuration, not having a www in the github pages settings, with a directory error during build in windows and another time when I inadvertently opened a second instance of a site so that it was calling for site assets from a separate port.

so pumped to try equations with 11ty!

the issue was in the build-cli. to make the cli exit cleanly, we manually call

process.exit

if you run

buildSiteV2

without the

--serve

option. unfortunately, this prevents 11ty post-build tasks from running (eg. copy the style sheets)

pushing an update to it now. will post here when its live

just a note that equations aren't out yet 😅 will aim to have that for monday's release!

thanks everyone for jumping on this and bringing it to my attention!

and its fixed!

Has anyone ever seen this error before? https://github.com/LukeCarrier/dendron/runs/1606454472?check_suite_focus=true#step:9:818

UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined

I have failed to repro this for some time now, I guess it's something to do with the different vault path between the runner and my machine

There are timeouts everywhere in the Windows tests, I need to sit and debug the promises to understand why they're never completed

hmm, i've seen it happen in

path.join

scenarios where we don't pass in a path. haven't seen it fail in that particular place but will also try to dig into it if i can get time today

https://github.com/dendronhq/dendron/issues/417 this looks like something I could pick up and start working today if anyone else isn't working on it.

do we have a document laying out any git conventions?

that issue is all yours. as for conventions, we use chore/feature/enhance. will document it tomorrow!

great.

quick question. should I look for all instances of the old parser and swap it out or is this issue just for the specified place?

just this place for the first issue

there are other places but we can create separate requests for that

got it.

looks like I need to learn what pods do 😄 can't test it without knowing what it does.

already on it 🙂

i am trying to push my changes to an new branch, but it says that I don't have permission?

can you fork and send a pull request?

replacing the old parser was simple enough (or I'm completely blanking on something), but I'm kinda lost with testing as I'm fairly new to js/ts tooling (especially developing for vscode). I keep digging through the codebase and find new stuff 😄 It's fun though. Python is my bread and butter and I'm stepping out of my comfort zone. Weirdly refreshing.

python was my first programming language and holds a special place in my heart 🙂 for testing, you can navigate to the test file inside vscode: https://github.com/dendronhq/dendron/blob/master/packages/pods-core/src/builtin/__tests__/MarkdownPod.spec.ts#L10:L10 once there, follow [these instructions](https://dendron.so/notes/cb22bd36-d45a-4ffd-a31e-96c4b39cb7fb.html#run-a-specific-test-from-non-dendron-plugin-package) to run all tests from a given file

yeah I spent a bit of time yesterday looking into the test codes. What I'm still trying to figure out are what cases to test for

MarkdownPublishPod

got it. the tests cover various functionality of the pods. there's a bit of incantation to setup the scaffoldingb because we run the logic in multiple places (eg. CLI and Plugin) which have different test runners (mocha & jest) and sometimes different engines (the thing that does indexing in engine). the core of the test logic is here but happy to go into more detail if its still confusing https://github.com/dendronhq/dendron/blob/master/packages/common-test-utils/src/presets/pods-core/markdown.ts#L112:L112

does the three test presets cover how the pods should function?

I did end up there and was wondering if those were enough or there should be more added for

MarkdownPublishPod

(as the .spec.ts didn't have tests for them yet and I wasn't sure if those presets were specific to

MarkdownImportPod

or just Markdown in general)