https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • k

    kevins8

    12/27/2020, 1:21 AM
    the three test there just cover the publishing aspect of the markdown pod
  • k

    kevins8

    12/27/2020, 1:21 AM
    there are separate tests for other functions like importing
  • h

    hikchoi

    12/27/2020, 1:22 AM
    oh
  • h

    hikchoi

    12/27/2020, 1:22 AM
    let me take a look at it again 😄
  • h

    hikchoi

    12/27/2020, 1:29 AM
    I think I assumed those test were for importing because of this bit
    Copy code
    typescript
          extra: {
            pod: new MarkdownImportPod(),
          },
  • k

    kevins8

    12/27/2020, 1:32 AM
    okay, my bad. those tests are for importing 😅
  • k

    kevins8

    12/27/2020, 1:32 AM
    i don't think we have tests for publish yet
  • k

    kevins8

    12/27/2020, 1:33 AM
    😳
  • h

    hikchoi

    12/27/2020, 1:34 AM
    hehe
  • k

    kevins8

    12/27/2020, 1:38 AM
    yeah, the import tests were linked to provide an example for how tests are setup. publish tests would be written in the same style
  • h

    hikchoi

    12/27/2020, 1:47 AM
    okay. Let's see if I can actually understand what pods do under the hood and write tests for publish 😄 I'll bug you with some questions after I've done some homework on them.
  • k

    kevins8

    12/29/2020, 5:24 PM
    @User if your interested in further customizations, feel free to take a look at the code (https://github.com/dendronhq/dendron-11ty). currently actively working on improving publishing so open to suggestions and ideas
  • l

    lukecarrier

    12/30/2020, 12:48 AM
    @User is this issue with note refs expected for now? https://github.com/LukeCarrier/dendron/runs/1624074641?check_suite_focus=true#step:9:1019
  • k

    kevins8

    12/30/2020, 12:55 AM
    that is the result of us not having ci/cd and me not running the test suite for the latest push 😅 . just fixed the tests and pushed!
  • l

    lukecarrier

    12/30/2020, 12:56 AM
    you hero
  • l

    lukecarrier

    12/30/2020, 12:56 AM
    I'm in the process of fiddling with the Windows build, I'm hoping I can get rid of all of the path issues with the snapshot filter
  • l

    lukecarrier

    12/30/2020, 1:15 AM
    peer deps for `dendron-next-server`'s
    react
    ,
    react-d3-tree
    and
    framer-motion
    are an issue on a fresh (post-cleanup) install, FYI
  • l

    lukecarrier

    12/30/2020, 1:15 AM
    I've added a new
    init-ci
    script that'll run
    lerna bootstrap
    with the
    --ci
    flag
  • l

    lukecarrier

    12/30/2020, 1:16 AM
    I wonder if it's worth us doing this by default for developer clones too, not sure if others have hit dependency resolution issues as often as I have or if it's just a side effect of working on CI 😅
  • k

    kevins8

    12/30/2020, 1:26 AM
    hmm, have not heard anyone running into peer dep issues but shouldn't hurt
  • l

    lukecarrier

    12/30/2020, 3:14 AM
    opts.extra.destPath
    is always undefined here https://github.com/LukeCarrier/dendron/blob/f58de1a4a56bc48326cc9adc036b7aac017e9471/packages/common-test-utils/src/presets/pods-core/json.ts#L257-L257 for me because
    opts.extra
    is set to a promise (
    resp
    here: https://github.com/LukeCarrier/dendron/blob/73f79dfa82d12b563d522d51cfd86b5a12e65b3c/packages/dendron-cli/src/commands/__tests__/exportPod.spec.ts#L60-L60). Even so,
    destPath
    isn't set in that result. I guess the result of
    setupTest
    needs to be returned from
    runEngineTestV4
    ?
  • k

    kevins8

    12/30/2020, 4:35 AM
    you're right, good catch!
  • k

    kevins8

    12/30/2020, 4:36 AM
    feel free to just skip that test as well since i need to clean up the pod tests anyhow
  • l

    lukecarrier

    12/30/2020, 4:36 AM
    sure thing
  • l

    lukecarrier

    12/30/2020, 4:37 AM
    I've gotta update Parallels to get the Windows build finished, but I think I have a pretty good replica of the Windows build agent now
  • l

    lukecarrier

    12/30/2020, 4:37 AM
    Nearly there... 😅
  • k

    kevins8

    12/30/2020, 5:11 AM
    you've been doing amazing work on the ci/cd work. thanks again for taking this on 🙂
  • l

    lukecarrier

    12/30/2020, 5:18 AM
    It's nice to have the time to contribute something 😀
  • k

    kevins8

    12/30/2020, 5:19 AM
    horray for the holidays 🥳
  • h

    hikchoi

    12/30/2020, 5:28 AM
    I'm jealous 😢 we don't have end of year holidays here. I am taking the last day off at least. I'll have time to work on the issue again 🙂
1...404142...108Latest