https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • k

    kevins8

    12/24/2020, 5:16 PM
    ah
  • l

    lukecarrier

    12/24/2020, 5:16 PM
    Jinx, I'll try Cygwin. I'm not sure what GitHub Actions does when shell is set to bash and the runner OS is Windows, so I'll have a play
  • k

    kevins8

    12/24/2020, 5:16 PM
    plugin tests did run under windows until the travis change which means newer updates (eg. backlinks) were not
  • l

    lukecarrier

    12/24/2020, 5:18 PM
    I can try running specific suites one by one to narrow it down, I had to do this on macOS earlier. It'd be really nice if
    vscode-test
    streamed output from the mocha instance inside of VS Code so we had something to go by when it just hangs, I'm not really sure where to start with that change though
  • k

    kevins8

    12/24/2020, 5:18 PM
    the reason you're seeing that error is because we're returning vscode uri's for backlinks which are unix style by default (https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/features/BacklinksTreeDataProvider.ts#L77:L77)
  • k

    kevins8

    12/24/2020, 5:18 PM
    but when we're comparing them in the test case, we're using
    path.join
    which changes to backslash
  • l

    lukecarrier

    12/24/2020, 5:19 PM
    thanks for the tip, I'll take a look
  • k

    kevins8

    12/24/2020, 5:19 PM
    one thing you can do is change the timeout value https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/test/testUtils.ts#L226:L226
  • k

    kevins8

    12/24/2020, 5:19 PM
    its currently set like this so that the test doesn't exist when we're debugging
  • k

    kevins8

    12/24/2020, 5:19 PM
    but that's hardly the case for ci/cd 😅
  • k

    kevins8

    12/24/2020, 5:20 PM
    you can also run the tests locally on your windows machine to narrow down what test is bad
  • l

    lukecarrier

    12/24/2020, 5:20 PM
    aaaah I totally missed this, thanks
  • k

    kevins8

    12/24/2020, 5:21 PM
    i'll add it to the documentation as well 🙂
  • k

    kevins8

    12/24/2020, 5:21 PM
    you can also debug individual test cases for the plugin
  • k

    kevins8

    12/24/2020, 5:21 PM
    https://dendron.so/notes/cb22bd36-d45a-4ffd-a31e-96c4b39cb7fb.html#run-specific-test
  • l

    lukecarrier

    12/24/2020, 5:21 PM
    I found this one 😅
  • s

    Stephen

    12/24/2020, 6:06 PM
    success with Ubuntu on wsl!
  • k

    kevins8

    12/24/2020, 6:17 PM
    👍
  • k

    kevins8

    12/24/2020, 6:17 PM
    will work out the windows issue as well in time, but probably going to be for after the holidays 😅
  • l

    lukecarrier

    12/24/2020, 7:29 PM
    I love it when we encounter issues in CI that aren't reproducible elsewhere 👍
  • f

    fudo

    12/24/2020, 7:30 PM
    That looks bad
  • l

    lukecarrier

    12/24/2020, 7:30 PM
    Looks like a missing stylesheet. Has anyone fired up devtools and checked the network tab?
  • f

    fudo

    12/24/2020, 7:31 PM
    On mobile no way to check
  • b

    Britt 2

    12/24/2020, 7:31 PM
    I ran into this at one point publishing mine locally, caused by an incomplete npx execution that only wrote like 3 files instead of 100; I believe the core issue was a missing folder
  • l

    lukecarrier

    12/24/2020, 7:32 PM
    @User what browser?
  • l

    lukecarrier

    12/24/2020, 7:32 PM
    generally you can attach desktop devtools to a mobile instance, it's a faff though
  • f

    fudo

    12/24/2020, 7:33 PM
    Brave and no desktop in sight
  • s

    Stephen

    12/24/2020, 7:33 PM
    I tried chromium firefox and mobile firefox, same thing
  • l

    lukecarrier

    12/24/2020, 7:35 PM
    Same on desktop Firefox for me
  • l

    lukecarrier

    12/24/2020, 7:35 PM
    Kevin's taking a look now
1...383940...108Latest