https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • c
    Grrr, just ran into a bug myself: https://github.com/dendronhq/dendron/issues/410. Happy to answer any questions here
  • f
    I have the feeling you could need some help with classifying the issues and to which Areas they respond to. I would offer to help with that.
  • k
    thanks for the report. this is currently the default behavior when creating a new note and there's text selected, regardless of where the text comes from. can see how this might be un-intuitive and will add a check if the file is coming from a known vault
  • l
    @User have you given any thought to a replacement for Travis for CI? ðŸŠĶ
  • k
    yeah, i was thinking github actions. been in my backlog for a while. is that something you would be interested in? 😅
  • l
    Yup! Were you happy with the matrix you had running before? It looks like a nice jumping off point 😁
  • k
    yep. basically porting the .travis.yml to github actions is the action item 🙂
  • k
    let me know if you run into any roadblocks. thanks for taking this on!
  • l
    @User how were you doing deployments, via Travis?
  • l
    I see 
    deploy.on: true
    but no provider configuration, was this set up in the UI?
  • k
    setting up the provider was done by connecting the github repo to travis.org. travis scans all repos for 
    .travis.yml
    file
  • k
    deploy.on: true
    was a setting to run a test on every push
  • l
    I think we need to figure out npm vs yarn for this. I was doing some reading and it looks like there are cases where 
    yarn install --frozen-lockfile
    can leave you with broken dependencies... any ideas? I think once that's fixed we should be good: https://github.com/LukeCarrier/dendron/actions/runs/434322506
  • k
    hmm, lets go all in on npm then. we've not been consistent about it in the past but we don't really use any special yarn features and this will lead to more reproducible builds
  • k
    you can run the following script to nuke everything
  • k
  • l
    I think the issue I was having here was a missing lock file for 
    engine-test-utils
    , since checking that in it seems to be working okay. I don't know if these versions match the ones you're working with on your setup so it might be better if you check that one in?
  • l
    I've been unclear when doing dev about the intersection between npm and yarn, it's a weird one
  • k
    i think the general recommendation is to not mix them 😅 i checked right now and I don't have a lock file. I think its because I installed with lerna bootstrap and it didn't generate one. lets use yours for now and i can update it if it breaks something
  • k
    engine-test-utils
    , as the name implies, is a testing package so its not even bundled with the plugin
  • l
    Yup, makes sense. Running 
    npm ci
    complains about there being no frozen versions to use during 
    lerna bootstrap
  • l
    Now I'm hitting a legitimate bug, I think 😅 I'm guessing wsRoot shouldn't be 
    undefined
    ? I hit this locally too: https://github.com/LukeCarrier/dendron/runs/1585582178?check_suite_focus=true#step:10:803
  • l
    Looks like it's undefined at 
    ExportPodCLICommand.run()
    , not sure what the caller is
  • k
    so that's actually expected because we're testing that dendron throws an error
  • k
    it looks like there's an issue with running the plugin tests
  • l
    Is there any way to clean up the promise rejection? I think Jest is exiting unsuccessfully because it gives up waiting for the promise
  • k
    yeah, i think so. for now, to test if that's the case, we can skip the test - its located here: https://github.com/dendronhq/dendron/blob/master/packages/dendron-cli/src/commands/__tests__/exportPod.spec.ts#L18:L18
  • k
    Copy code
    Downloading VS Code 1.52.1 from https://update.code.visualstudio.com/1.52.1/linux-x64/stable
Downloaded VS Code 1.52.1 into .vscode-test/vscode-1.52.1
Exit code:   null
Done


lerna ERR! npm run test -- -u stderr:
Failed to run tests
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @dendronhq/plugin-core@0.20.1-alpha.11 test: `node ./out/test/runTestInteg.js "-u"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @dendronhq/plugin-core@0.20.1-alpha.11 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2020-12-20T19_46_40_835Z-debug.log

lerna ERR! npm run test -- -u exited 1 in '@dendronhq/plugin-core'
lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately.
  • k
    can we get the output at 
    /home/runner/.npm/_logs/2020-12-20T19_46_40_835Z-debug.log
    ?
  • l
    Yup, I'll add a failure branch to upload them in a second. Might be worth doing this for the Jest snapshots too, anything else you can think of?
1...343536...108Latest