good catch! i had it symlinked locally when developing 😅 pr request is good. would you mind also signing the CLA?

Signed!

merged!

So, a bit confused as to actually see changes to code reflected in a dev environment. I've cloned, installed, built, now I'm in vs-code using the dendron.code-workspace file. I tried to do something that I'd hopefully see reflected, so I changed the LINK_REGEX in dendronLinksPlugin.ts in engine-server/src/topics/markdown/plugins to some nonsense, hoping that would break wiki links

but, it hasn't... I've tried rebuilding, and running the api-server: test launch server build command. So I'm thinking the engine code isn't being used in the dev setup I'm in. Is there something here I'm forgetting?

1. are you using the

Run extension

command on the debugger panel to test dendron? https://dendron.so/notes/64f0e2d5-2c83-43df-9144-40f2c68935aa.html#4-start-debugging-the-plugin 2. if you have one vscode instance which you have dendron installed and are also doing dendron development on, you might get a version conflict. in that case, use

Run extension with plugin disabled

in the debugger panel (or use a different version of vscode to run dendron vs develop)

Ah, thank you, that was definitely the issue. Is there a proper way to run the extensions with plugins disabled (to avoid a version conflict) but also enable markdown links/notes/etc.? I have a working dev environment now afaik, but wiki links aren't showing up in preview I predict because the markdown notes plugin is disabled. Or should this work by default?

we stopped relying on markdown notes and have migrated all markdown functionality into dendron. the only extensions we rely on are preview and graphs at this point

there should be a debug option called “run with extensions disabled” or something to that effect

the other solution is to use vscode insider/vscodium for development

Ah, I made a new workspace in the extensions disabled build, and the wiki links worked, then I was able to see changes in code reflected in the dev environment. Exciting! Thank you!

Sorry for all the questions, but is there an obvious reason why 'Markdown Preview Enhanced' isn't available in the dev environment? Only seeing an option to do a standard Markdown preview

e.g. wiki links and other dendron specific markdown elements are unavailable (but seemingly working in the editor--autofill still works)

did you start with plug-ins disabled? if so, the preview would be disabled 😅

Oh!!! haha oops. Glossed right over the fact you just said that Dendron still relies on plugins for preview

let me know if you're running into anything funky doing setup. besides for the extension stuff, the other stuff should work as expected 🙂

i'm also curating our backlog at the moment so let me know if you're in the mood for some good first time tasks 😇

Nope, no further issues! Managed to manually install the preview plugin and have been tinkering around in the code trying to piece together what is where. I'd love to hear what those first time tasks are if you have any available!

this is our current list of good first tasks: - https://github.com/dendronhq/dendron/labels/size.small I would recommend starting off with something like this: - https://github.com/dendronhq/dendron/issues/344 here's the code where notes get created: https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/components/lookup/LookupProviderV2.ts#L69:L69

fantastic, that looks like a good first target. I'll probably shift gears to some easier tasks, but I was actually looking into this issue report: https://github.com/dendronhq/dendron/issues/334, and was able to intercept where WikiLinks were parsed for the internal representation of a note, but am I right to say that this issue has more to do with the preview plugin than the main dendron plugin code?

basically, if I had a note like [[|foo]], I could successfully intercept the parsing to change the alias to 'foo' instead of '|foo', but the change wasn't reflected on the preview (it would still just appear as '|foo'. I'm wondering if the display logic for wiki links actually draws from the internally parsed link information in dendronLinksPlugin.ts or not. A clue for me was that even when changing the alias divider to something other than '|', the preview still treated '|' as an alias divider

yeah, the preview code is in a different repo 😅 doing a rewrite of the dendron markdown parsing to make it simpler going forward

sweet, made my first ever open-source pull request 😅 I'll stick around and hopefully help out with some of the easier tasks in the backlog!

thanks for moving quickly on this. left a few comments. will also find some additional good starter tasks in the backlog for future consideration 🙂

alright, I think I took care of the requirements! Fixed the issue, and added a test. However, the Travis build failed? Everything builds and runs fine on my machine, and the test case I added passes. Perhaps the test case isn't properly implemented, or it's an unrelated update causing the build to fail?

ignore the travis build, i disabled it because they changed the pricing model 😅

just merged! you are now officially a

@Horticulturalist

👨‍🌾

@User just merged your pull request :) thanks for doing the build. adding search is making sure this [js](https://github.com/dendronhq/dendron-jekyll/blob/master/assets/js/just-the-docs.js#L53:L53) is copied to assets during runtime. let me know if you want to take this as well and if you need more details i've also updated the setup instructions: https://github.com/dendronhq/dendron-11ty/blob/main/README.md#L29:L29 11ty now builds pages with dendron formatting and is a whole lot faster (+200 pages in ~10s) 🚀 🚀 🚀 i think we should have something ready for people to test with next week!

Hi @User! I just submitted a long-ish bug report: https://github.com/dendronhq/dendron/issues/406 and I just wanted to let you know I am often lurking here on the Dendron Discord (daytime/early evening, European time) in case you wish to chat about it. I might not respond immediately, but if you @ mention me I get an email notification and will try to pop in asap. Otherwise I am more than happy to interact via the GitHub issue too.

@User thanks for the detailed bug report! i've recently ran into this myself and will be addressing this for the next release!