https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • k

    kevins8

    12/20/2020, 8:22 PM
    we can also split up the tests - (eg. only run CLI tests and then only run plugin tests). it looks like its the plugin tests that are failing but they've been known to be flaky in the past. if it is the plugin tests, i'm also okay with initially just doing the CLI tests and adding the plugin tests later
  • l

    lukecarrier

    12/20/2020, 8:22 PM
    I can put them into the matrix so they'll run separately if that works? How do you differentiate between them?
  • k

    kevins8

    12/20/2020, 8:31 PM
    plugin tests is the
    test
    task in
    plugin-core
    . cli test is the
    test
    task in everything else 😅
  • k

    kevins8

    12/20/2020, 8:32 PM
    currently, the ci script doesn't differentiate since we run
    npx lerna run test --parallel
  • l

    lukecarrier

    12/20/2020, 8:32 PM
    sweet, I can work with that*
  • k

    kevins8

    12/20/2020, 8:33 PM
    we could break it along the following lines
    npx lerna run test --parallel --ignore @dendronhq/plugin-core
    and
    npx lerna run test --scope @dendronhq/plugin-core
  • l

    lukecarrier

    12/20/2020, 8:34 PM
    Yeah, for now I can add two conditional script actions and toggle them on and off
  • l

    lukecarrier

    12/20/2020, 8:59 PM
    Looks like Travis ran with
    jest -u
    , so I'm getting some snapshot failures now. There are some absolute paths dotted around, especially with cwd properties 😅
  • l

    lukecarrier

    12/20/2020, 9:00 PM
    I'll pick this up tomorrow, but we're really close; progress on my fork: https://github.com/dendronhq/dendron/compare/master...LukeCarrier:github-actions
  • k

    kevins8

    12/20/2020, 9:42 PM
    awesome, thanks for putting in the ground work! will also take a look and see if there's anything obvious that can be adressed on my end
  • k

    kevins8

    12/20/2020, 11:17 PM
    I've had a bunch of folks ask for good first time tasks so I've gone and added some. Feel free to reply here if you're interested in taking them on - good first time tasks 🌱 - update dendron ui configuration: https://github.com/dendronhq/dendron/issues/416 - don't modify notes that are not from a vault: https://github.com/dendronhq/dendron/issues/410 - use new dendron parser when publishing using markdown pod: https://github.com/dendronhq/dendron/issues/417 - pretty urls for dendron: https://github.com/dendronhq/dendron/issues/329 If you're in the mood for something more adventurous, here is a list of good second time tasks 💪 - sort lookup results by last modified: https://github.com/dendronhq/dendron/issues/330 - Create Option to Insert Ref after Note: https://github.com/dendronhq/dendron/issues/415 - ignore empty refs when doing a wildcard note ref: https://github.com/dendronhq/dendron/issues/363 the second time tasks dont have much detail so ping me if you're interested and I will add detail! @User @User @User @User @User
  • h

    hikchoi

    12/20/2020, 11:18 PM
    I'll take a look after work!
  • f

    fudo

    12/21/2020, 10:56 AM
    @User Since I'm a fan of the Graph View I would love to tackle improving it. And since I'm currently looking into Graph visualisation, for various projects I'm getting to know d3.js anyway. So I would like to know where I should start with it and if their is a way to well request a Note / Hirachy list from the Engine / the Server.
  • h

    hikchoi

    12/21/2020, 4:07 PM
    currently setting up for development. after a fresh build I grabbed a test to see if it runs. Seems like it can't find the test file?
    Copy code
    Uncaught Error: Cannot find module '/Users/hikchoi/dev/dendron/packages/pods-core/lib/MarkdownPod.spec.js'
    could anyone give me some pointers to get this running? 🙂
  • h

    hikchoi

    12/21/2020, 4:10 PM
    I'm probably blanking on something stupid but it's quite late haha. it was a long day. I'll check discord tomorrow and try this again.
  • k

    kevins8

    12/21/2020, 5:08 PM
    responded to the github issue on edge based graphs. will add some more detail to it later today!
  • k

    kevins8

    12/21/2020, 5:08 PM
    hmm, did you go through the launch sequence in the setup docs? https://dendron.so/notes/64f0e2d5-2c83-43df-9144-40f2c68935aa.html
  • h

    hikchoi

    12/21/2020, 5:49 PM
    yeah I did follow that document.
  • h

    hikchoi

    12/21/2020, 5:52 PM
    I did have to specify which node I wanted vscode to use so I had to add that to tsconfig. but other than that I started with a fresh clone.
  • k

    kevins8

    12/21/2020, 11:44 PM
    what command did you run to get that error? are you running it via VSCode or the CLI?
  • h

    hikchoi

    12/22/2020, 12:07 AM
    I ran
    pods-core:test file (pods-core)
  • k

    kevins8

    12/22/2020, 1:38 AM
    got it. that command is meant for debugging non-test files. you want to run
    npm:test:watch pods-core
    with the file open to run the
    .spec.ts
    files
  • h

    hikchoi

    12/22/2020, 3:12 AM
    doh. knew I did something wrong 😄
  • k

    kevins8

    12/22/2020, 3:47 AM
    all good 🙂
  • b

    bublucious

    12/22/2020, 8:34 PM
    Thanks for the task suggestions, I'll take a look when I have some time later!
  • s

    Stephen

    12/23/2020, 12:10 AM
    I tried the 11ty quick start on Ubuntu 20.04.1 and got a stacktrace from "EleventyConfigError" @User should I open issues for this and the Windows 10 hiccup?
  • b

    Britt 2

    12/23/2020, 12:15 AM
    what was the config error? Kevin did some troubleshooting with me earlier today in #735365126227493004 related to some issues I was having, the first of which (actually last night) was an eleventy config error that was caused by node not being version>=12
  • k

    kevins8

    12/23/2020, 12:36 AM
    yeah, if you can attach the details, that would be great
  • k

    kevins8

    12/23/2020, 3:36 AM
    so i tried to repro this and was unable to. used windows server 2019 edition and node v14.15.3. can you post the error you had on the issue?
  • s

    Stephen

    12/23/2020, 3:52 AM
    I changed versions of node and ended up with a different error message. I'll post all future stack traces https://github.com/dendronhq/dendron-11ty/issues/7
1...353637...108Latest