the price of inexperience

thank you

the function is useful for comparing versions in the format you've mentioned - otherwise you'd have to split the version string into components to check 1.9.12 < 1.10.1 etc (if you just did >= on the strings directly from memory that's a string comparison, which most of the time isn't what you want)

that works much better already, thank you for correcting the approach, rather than just answering the question

could someone validate this for me please, I've just made a simple change to an existing module to put in a version check so version check and then 'elseif' if the condition is not met, looks good to me https://gist.github.com/ikonia/15f9c15ac554a1e23d64461fa570c03f - however the parser complains "Error: Could not parse for environment production: Syntax error at '}' (file: /home/mattd/git/puppet-consul/manifests/params.pp, line: 32, column: 5)" line 32 is the final closing brace - which I don't see why it's a problem as it closes the elseif

It should be

elsif

, plus the comparison operator should be

==

not

=

ie:

} elsif versioncmp ($::version, '1.9.11') == -1

great spot, I'd not seen the else typo

I did just spot the == though as I posted, thank you

thought the validator would have been more helpful

that fixed it, thank you

This message was deleted.

My question is, will the command creates => find the newly created command and not repeat it ? I would like it to run only once when typing the command

the "brand.txt" is a long command code put into one doc

The way the

creates

parameter works is that puppet checks for the existence of the argument of that parameter before running the command. If that file exists, nothing happens. So the expectation is that the command “creates” the file, and thus the existence of the file means that the command has already run and does not need to be run again. In your example it appears that the file you are specifying to

creates

has to already exist since it is referenced in the command. So what you have won’t work.

whampi1 command should be accessible via path. so either provide full path to the command or fix path argument, so it has the directory in it, which has that command

think of it as setting PATH variable

This message was deleted.

do I need to explicitly say this is running with a shell?

I would change it an use a fact

there already is a Timezone fact?

I think so

It is all lowercase

indeed there is

but I can put that into an exec like this?

exec { 'set UTC time':
    command => '/usr/bin/timedatectl set-timezone UTC',
    unless  => $facts['timezone'] == 'UTC'
  }

nope

this would work too

unfortunately, that doesn't work across OS releases

timedatectl either 🙂