Puppet Community

I've had great success using create_resources.

...except for the resource ordering.  :slightly_smiling_face:

It's an outdated construct from the time when iterations were not present in puppet
```class profile::users {
  Hash $list = {},
} {
  $list.each | $user, $attributes| {
    user { $user:
      * =&gt; $attributes,
      before =&gt; Class['my_class'],
    }
}```

Thanks for the tip.  I'll look into iterations as you suggest.  I've been out of the Puppet scene for about five years and a lot has changed.

yeah, that looks a lot better.  Thank you.

<@U2S1MUUQ7> could you please share any docs that says that create_resources() is outdated? I mean official docs.

<https://puppet.com/docs/puppet/6/function.html#create-resources> The use is discouraged :)

Don't think that 'use selectively' means "don't use as it's outdated'"

For create_resources, there's been some discussion on the slack about why it's discouraged, and the gist of it was that it isn't the equivalent of actually looping over the resources and creating them in all cases, so that person strongly recommended you do iteration+individual resources

if nothing else, create_resources is very opaque to the next person who has to read through it all, the iterative version has a thing that looks like a resource.

```        @user { $this_user:
          ensure           =&gt; present,
          password         =&gt; "${engops_users[$this_user][password]}",
          gid              =&gt; "${engops_users[$this_user][gid]}",
          uid              =&gt; "${engops_users[$this_user][uid]}",
          comment          =&gt; "${engops_users[$this_user][comment]}",
          managehome       =&gt; true,
          groups           =&gt; "${engops_users[$this_user][groups]}",
          shell            =&gt; '/bin/bash',
          password_max_age =&gt; '-1',
        }```

and I have the following hiera

```  joeuser:
    comment: "joe user"
    uid: "4001"
    gid: "4001"
    groups:
      - 'yubikeyusers'
      - 'wcis'
      - 'wheel'
    password: "SHA" ```

```Group names must be provided as an array, not a comma-separated list. ```

The groups are being specified as an array already.

so I'm not sure why it doesn't like them.

meaning the `"${engops_users[$this_user][groups]}"`

Same for your other attributes btw :wink:

most of those quotes are useless. drop them and directly reference the variable

<https://puppetcommunity.slack.com/archives/C0W298S9G/p1652377751924469>

same deal, no need to duplicate attributes and support just a limited set of the resource's attributes