Puppet Community

but `if "something" in $facts` isnt bad or maybe

The tree_each() function does that (walks everything in nested hash/arrays

I had just assumed it wouldn't be possible to do this in puppet code. Neat.

Hmmm. How do you turn an Iterator into a nested hash?

Look at the docs, there are options for what you want to visit - for example all containers or all key/values (or values skipping containers).

You get the path to each element, and the value

I see that but I need to a the result to be a hash that I can pass on to another function.

If hash has a nested hash a with keys x, y you will get [a, x], val then [a,y], val

You can create s new hash from an array with path, val pairs

Takes a bit of tinkering with. The function to get the hang of it.

I think my real problem is that learned puppet in the 2.x days and still think of all variables as immutable...

Well they are immutable. What you do is transform to a shape that you process and theb transform to the shaoe you want the result to have

I would not consider building up a new hash from within a iterative block strictly immutable.

Some examples here. <https://groups.google.com/g/puppet-users/c/0M_PwfzdsaE/m/4voHvE4TCgAJ|https://groups.google.com/g/puppet-users/c/0M_PwfzdsaE/m/4voHvE4TCgAJ>

It is a new value just like $a+$b produces a new value

Immutable is that variables can not be altered once it has an assigned value.

And you cannot alter values either - only produce new values (and use or assign to new variable).

I can see that perspective in terms of the lvalue but it is a block of code which is evaluated multiple times to build up a data structure.

The tree_each flattens the entire structure. To achieve this it uses the path to each element.

in the market for puppet module that manages OpenSSH? Anyone seen/hear/smell anything like that around?

<https://forge.puppet.com/modules?limit=25&amp;sort_by=rank&amp;module_groups=base%20pe_only&amp;utf-8=%E2%9C%93&amp;sort=rank&amp;q=ssh&amp;os=windows>

you can filter by OS on the left sidebar.

I have zero experience with any of them however.

<https://forge.puppetlabs.com/modules/ploperations/ssh/>

Does a `subscribe` parameter tell puppet to also autorequire those resources?

autorequire is an implicit term for the providers

Like if I put `subscribe =&gt; File['/blah'],`then puppet will also require that without me specifying `require =&gt; File['/blah'],` as well?

<https://www.puppet.com/docs/puppet/7/lang_relationships.html#lang_rel_metaparameters>

Yup, `notify` and `subscribe` are super-sets of `before` and `require`.

it turns out that puppet doesn't have a square built-in function and I had to use ruby.

Now, ideally, I will be able to generate the VXLAN ID. Ubuntu says it's a number in the range 1-16777215, it has to be a unique number, and I can use `192.168.1.0/24` as a seed.
What was the name of the function to generate random number, based on a string? not fqdn_rand

Is there a place to open a ticket for this? I'm not sure if the cloud-jira is made for public use?

I haven't logged in to cloud jira yet, but you could create a ticket in the past

```Puppet's public facing Jira projects will be moving to a new Jira Cloud instance at <https://puppet.atlassian.net> starting on Friday 2023-03-10.```

so you can still submit ticket in old jira

Wow was that painful, but here it is
<https://tickets.puppetlabs.com/browse/MODULES-11395>

Don't you need to run pre-apply or something like that when you need facts?

<https://www.puppet.com/docs/bolt/latest/plan_functions.html#apply-prep>

Have a package resource thats installing an RPM package and it insists on reinstalling it over and over again.  I just have it set to present so it shouldn't be using the version number but even though the server thinks its installed Puppet keeps thinking it isn't.  Anyone have any suggestions?

try `puppet resource package package_you_install`

it might have a different name that you think it is

I've tried making sure the Gem versions all line up, and even did a totally clean re-install of PDK (`apt remove pdk` followed by `rm -rf /opt/puppetlabs/pdk`) but same behavior.

I am unable to reproduce:
```oryx ~/testing $ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.5 LTS"

oryx ~/testing $ dpkg -l pdk
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version        Architecture Description
+++-==============-==============-============-=================================
ii  pdk            2.6.1.0-1focal amd64        Puppet Development Kit```
what version of pdk?

`2.6.1.0` as well:
```||/ Name           Version        Architecture Description
+++-==============-==============-============-=================================
ii  pdk            2.6.1.0-1focal amd64        Puppet Development Kit```

sent another reply outside the thread by accident. Check that, too, please

Gemfile.lock

Yeah, I did `pdk bundle install` as well, and didn't get any errors. Here's the `Gemfile.lock` as well. Thanks for looking into it!

I have a couple of differences which are just slightly newer than yours, having run bundle just now. :thinking_face:
```--- Gemfile-skylar.lock 2023-03-06 18:21:59.642242414 -0500
+++ Gemfile.lock        2023-03-06 18:16:12.860888300 -0500
@@ -11 +11 @@
-    aws-partitions (1.700.0)
+    aws-partitions (1.707.0)
@@ -17 +17 @@
-    aws-sdk-ec2 (1.361.0)
+    aws-sdk-ec2 (1.364.0)
@@ -22 +22 @@
-    bindata (2.4.14)
+    bindata (2.4.15)
@@ -68 +68 @@
-    excon (0.97.2)
+    excon (0.99.0)
@@ -164 +164 @@
-    multipart-post (2.2.3)
+    multipart-post (2.3.0)
@@ -262 +262 @@
-    puppet-syntax (3.2.1)
+    puppet-syntax (3.3.0)
@@ -311 +311 @@
-    rspec-core (3.12.0)
+    rspec-core (3.12.1)
@@ -377 +377 @@
-    specinfra (2.84.0)
+    specinfra (2.84.1)```

does your .sync.yml include any additional gems?

ok, this is the relevant code that is failing:
```# Add all spec lib dirs to LOAD_PATH
components = module_path.split(File::PATH_SEPARATOR).collect do |dir|
  next unless Dir.exist? dir
  Dir.entries(dir).reject { |f| f =~ %r{^\.} }.collect { |f| File.join(dir, f, 'spec', 'lib') }
end
components.flatten.each do |d|
  $LOAD_PATH &lt;&lt; d if FileTest.directory?(d) &amp;&amp; !$LOAD_PATH.include?(d)
end```


looks like it is complaining about walking the spec tree, which is odd, as pdk adds that bit

Here's the output from the completely unmodified test module I made (wanted to avoid potential problems from `git`) -
```[skylar2@thargelion ~/tmp/spectrum_protect_client]$ tree
.
├── appveyor.yml
├── bin
│   ├── rake
│   └── rspec
├── CHANGELOG.md
├── data
│   └── common.yaml
├── examples
├── files
├── Gemfile
├── Gemfile.lock
├── hiera.yaml
├── manifests
│   └── init.pp
├── metadata.json
├── Rakefile
├── README.md
├── spec
│   ├── classes
│   │   └── spectrum_protect_client_spec.rb
│   ├── default_facts.yml
│   ├── fixtures
│   │   ├── manifests
│   │   │   └── site.pp
│   │   └── modules
│   │       └── spectrum_protect_client -&gt; /home/skylar2/tmp/spectrum_protect_client
│   └── spec_helper.rb
├── tasks
└── templates

13 directories, 16 files```

weird, the only thing I see different is yours did not create `spec/{defines,functions,hosts}` otherwise mine is the same. They are empty dirs see if creating them changes anything

Yeah, I was wondering if those needed to be present, though I just made them and get the same error from `pdk test unit` -
```An error occurred while loading ./spec/classes/spectrum_protect_client_spec.rb.
Failure/Error: require 'puppetlabs_spec_helper/module_spec_helper'

TypeError:
  no implicit conversion of nil into String
# /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/gems/puppetlabs_spec_helper-4.0.1/lib/puppetlabs_spec_helper/module_spec_helper.rb:61:in `directory?'
# /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/gems/puppetlabs_spec_helper-4.0.1/lib/puppetlabs_spec_helper/module_spec_helper.rb:61:in `block in &lt;top (required)&gt;'
# /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/gems/puppetlabs_spec_helper-4.0.1/lib/puppetlabs_spec_helper/module_spec_helper.rb:60:in `each'
# /opt/puppetlabs/pdk/share/cache/ruby/2.7.0/gems/puppetlabs_spec_helper-4.0.1/lib/puppetlabs_spec_helper/module_spec_helper.rb:60:in `&lt;top (required)&gt;'
# ./spec/spec_helper.rb:7:in `require'
# ./spec/spec_helper.rb:7:in `&lt;top (required)&gt;'
# ./spec/classes/spectrum_protect_client_spec.rb:3:in `require'
# ./spec/classes/spectrum_protect_client_spec.rb:3:in `&lt;top (required)&gt;'
No examples found.```

oh, wait, did you rename `manifests/init.pp`  to be `manifests/site.pp`?

site.pp is a control repo file, not a component module file

No, I have a `spec/fixtures/manifests/site.pp` file, but only `manifests/init.pp` in the module tree.

:confused: why is a .pp file in a spec dir?

It looks like `pdk test unit` is creating it, though I'm new to this so might be confused. :slightly_smiling_face:

I'm out of suggestions other than going to `/opt/puppetlabs/pdk/share/cache/ruby/2.7.0/gems/puppetlabs_spec_helper-4.0.1/lib/puppetlabs_spec_helper/module_spec_helper.rb:61`  and putting in some debugging statements as to why it can't find the directories

is there anything odd about perms in /tmp? Have you tried in your home dir?

`/tmp` looks normal (`1777`), and right now am running the tests out of my home directory. I'll try the debugging route tomorrow and report back - I was worried I was missing something basic, possible there's just something weird with my laptop... :shrug::skin-tone-3:

Thanks, and thanks again for a second pair of eyes!

Unfortunately I've gotten bogged down in other work but hopefully will be able to return to this tomorrow. Thanks for following up!

<@U2HGUG2CD> <@UNNE9882X> It does look like there's some `nil` entries in the `components` array. I'll try to track down where those are coming from but I'm guessing that that's the source of the error:
```components = [["/home/skylar2/git/uwgsit/puppet-spectrum_protect_client/spec/fixtures/modules/spectrum_protect_client/spec/lib"], [], [], nil, ["/usr/share/modules/modulefiles/use.own/spec/lib", "/usr/share/modules/modulefiles/modules/spec/lib", "/usr/share/modules/modulefiles/dot/spec/lib", "/usr/share/modules/modulefiles/module-info/spec/lib", "/usr/share/modules/modulefiles/module-git/spec/lib", "/usr/share/modules/modulefiles/null/spec/lib"]]```


OK, I've tracked this down. `components` is set from `module_path`, which is the combination of the path to the `modules` directory in `fixture_path` and the contents of the `MODULEPATH` environment variable. I'm not totally sure what `MODULEPATH` is used for in the context of `pdk`/`rspec` but it's also used by `environment-modules`, which provides a way of making scalable changes to user shell environments via Tcl scripts.

The problem is that the `environment-modules` shell profile adds this to `MODULEPATH`: `/usr/share/modules/$MODULE_VERSION/modulefiles`

For `environment-modules`, `MODULEPATH` is used within Tcl and not shell, and `$MODULE_VERSION` is interpolated by Tcl based on the value of that Tcl variable.

Within `module_spec_helper.rb`, though, the block that produces the components array interprets it literally and discards it, but `collect` will set a value to `nil` if nothing else is returned by that iteration. I think the quickest fix will be to have a `reject` filter that produces an array that has no `nil` values in it.

Maybe you can reset the MODULEPATH in spec_helper

Even better, that works as well. Is it worth a PR? I'm happy to just document it locally for my coworkers

I’m not sure.. I’d say this is clash of multiple softwares which is mostly local for your setup. Though it might be good idea to document the env vars.. I don’t remember if it’s documented anywhere 

No, this is only on Ubuntu. Our Ubuntu build includes `environment-modules` since our HPC environment requires it, but we don't have it setup for FreeBSD, so that's why it's only showing up on Ubuntu for us.

I'm guessing it would be an issue for FreeBSD as well if we did have it installed.

I'm not actually sure what `MODULEPATH` is used for in the context of `pdk`, but adding a filter to the generation of `components` seems to work and that seems to be a more targeted solution.
```# Add all spec lib dirs to LOAD_PATH
components = module_path.split(File::PATH_SEPARATOR).collect do |dir|
  next unless Dir.exist? dir
  Dir.entries(dir).reject { |f| f =~ %r{^\.} }.collect { |f| File.join(dir, f, 'spec', 'lib') }
end.reject { |f| f == nil }```