that's a string, it will mean true

var: null

is valid YAML for null/nil

The same as

var:

or

var: ~

How are you pulling that data from Hiera? “if $var is defined in Hiera” doesn’t really mean much until that data is pulled into Puppet.

APL, so my_class::var

What does

puppet lookup my_class::var

say about it?

Try changing to

~

instead of

null

. I recall hitting something where

null

was being cast to a string, butI can’t remember if that was just in spec tests or in real Puppet runs.

Try changing to

~

instead of

null

. I recall hitting something where

null

was being cast to a string, butI can’t remember if that was just in spec tests or in real Puppet runs.

Puppet 7 treats

var: null

as null (not a string) ... ¯\_(ツ)_/¯

found the key right where expected value: nil

What does the parameter definition look like? Also, maybe trying `notify`’ing the variable just as a quick sanity check of what it is.

should puppet lookup find the value when its undef? I thought it says "didnt find value X"

so seems it is evaluating the hiera yaml as documented but the conditional is treating nil as true on an if... should i convert to bool..

null values that are converted to strings get converted as

''

which is true iirc

or i guess more accurately

undef

values

Is there a default value or something that’s getting pulled in? I just did a test, and on both puppet 6.17.0 and 7.17.0, both

~

and

null

are correctly pulled in as

undef

via APL.

# test/manifests/init.pp
class test (
  $param1,
  $param2,
) {
  notify { 'param1':
    message => "type: ${type($param1)}: ${param1}",
  }
  notify { 'param2':
    message => "type: ${type($param2)}: ${param2}",
  }
}

---
# common.yaml
test::param1: ~
test::param2: null

Puppet 6.17.0 and 7.17.0 both produce this:

Notice: type: Undef:
Notice: /Stage[main]/Test/Notify[param1]/message: defined 'message' as 'type: Undef: '
Notice: type: Undef:
Notice: /Stage[main]/Test/Notify[param2]/message: defined 'message' as 'type: Undef: '

```- took a hit! Ouch. (Karma: -71)

@spin Check for a default value in the parameter’s definition, and also make sure you’re not quoting the variable in the

if

conditional.

so yea did essentially the same test as you and got the same result.. in an if the code doesnt execute the if on a null/nil value. validated with lookup cli and code review the only value defined is null.. going to take another look at debug output as to why it looks to be executing the wrong code block..

thanks for everyones input, will report back once i nail down.. whats going wrong

bah it was a pick i spaced on adding a couple weeks ago in control repo... pick($_package_url, null),

This message was deleted.

See the

puppetlabs-firewall

module at https://forge.puppet.com/puppetlabs/firewall?src=slack&channel=puppet

To make

puppetlabs-firewall

useful on SLES 15, I had to make the following changes: • added code to persist firewall rules, when they change, pseudo-code as follows:

Firewall {
  notify => Exec['persist-firewall-rules'],
}

• disable

firewalld

in

systemd

• added

systemd

service for

iptables

◦ stop will flush the

iptables

rules ◦ start will load the

iptables

rules from the persisted location

I've created https://github.com/puppetlabs/puppetlabs-firewall/pull/1061 This will allow me to remove the firewall persistence code, which is peppered all over the code base (essentially in any class which has a firewall rule applicable on the Suse platform). Any eyes on the pull request or feedback/comments are welcome.

I've created https://github.com/puppetlabs/puppetlabs-firewall/pull/1061 This will allow me to remove the firewall persistence code, which is peppered all over the code base (essentially in any class which has a firewall rule applicable on the Suse platform). Any eyes on the pull request or feedback/comments are welcome.

so i am not loving the solution i came up with to touch 4 or 5 modules and change data type from optional String to variant string,undef, boolean.. and i dont get why this is necessary... if you have a module that has hiera default of null for an optional param. why wouldnt specifying $var => null when declaring the class be exactly the same

You mean

~

in common.yaml? Looks like a smell: better default to

undef

in the manifest.

well i want to define all defaults in module hiera and learned that i need null in hiera.. which then parses to undef in puppet