<#249 Bugfix/update pact url> Pull request opened ...
# pact-php
g
#249 Bugfix/update pact url Pull request opened by Lewiscowles1986 This should fix master builds. At least it seems to in my local Command
Copy code
git clone <https://github.com/Lewiscowles1986/pact-php>
cd pact-php
git checkout bugfix/update-pact-url
composer install
php vendor/bin/phpunit tests\\PhpPact\\Standalone\\Broker\\BrokerTest.php
Notes: • I Changed the formatting of some of the file to make it easier to step-through in a debugger and find the problem. While concise the prior code was not helping me to find the problem. • It reads like the config & broker initialization could be delegated to a short-hand function
withBroker()
. What do you think about this? pact-foundation/pact-php GitHub Actions: PHP 8.0 on windows-latest with locked dependencies GitHub Actions: PHP 8.0 on windows-latest with lowest dependencies GitHub Actions: PHP 7.4 on windows-latest with locked dependencies GitHub Actions: PHP 7.4 on windows-latest with lowest dependencies GitHub Actions: PHP 7.3 on windows-latest with locked dependencies GitHub Actions: PHP 7.3 on windows-latest with lowest dependencies GitHub Actions: PHP 8.0 on macos-latest with locked dependencies GitHub Actions: PHP 8.0 on macos-latest with lowest dependencies GitHub Actions: PHP 7.4 on macos-latest with locked dependencies GitHub Actions: PHP 7.4 on macos-latest with lowest dependencies GitHub Actions: PHP 7.3 on macos-latest with locked dependencies GitHub Actions: PHP 7.3 on macos-latest with lowest dependencies GitHub Actions: PHP 8.0 on ubuntu-latest with locked dependencies GitHub Actions: PHP 8.0 on ubuntu-latest with lowest dependencies GitHub Actions: PHP 7.4 on ubuntu-latest with locked dependencies GitHub Actions: PHP 7.4 on ubuntu-latest with lowest dependencies GitHub Actions: PHP 7.3 on ubuntu-latest with locked dependencies GitHub Actions: PHP 7.3 on ubuntu-latest with lowest dependencies 4 other checks have passed 4/22 successful checks
l
Ah, now I'm running it in my GitHub actions it sometimes fails, but other times not... https://github.com/Lewiscowles1986/pact-php/actions/runs/2380311568 I think there are race conditions in the code.
And I don't mean the few lines of config I shuffled around